From 2748d230ac804e850784361534d2a95ef7ff10a0 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 5 Feb 2025 10:57:57 +0100 Subject: [PATCH] ref(core): Remove unused special handling for `Debug` integration This integration is removed in v9 so we do not need this code anymore. --- packages/core/src/integration.ts | 14 +------ packages/core/test/lib/integration.test.ts | 46 ---------------------- 2 files changed, 1 insertion(+), 59 deletions(-) diff --git a/packages/core/src/integration.ts b/packages/core/src/integration.ts index 1d3dcc713934..31d5426d4fbc 100644 --- a/packages/core/src/integration.ts +++ b/packages/core/src/integration.ts @@ -60,19 +60,7 @@ export function getIntegrationsToSetup(options: Pick integration.name === 'Debug'); - if (debugIndex > -1) { - const [debugInstance] = finalIntegrations.splice(debugIndex, 1) as [Integration]; - finalIntegrations.push(debugInstance); - } - - return finalIntegrations; + return filterDuplicates(integrations); } /** diff --git a/packages/core/test/lib/integration.test.ts b/packages/core/test/lib/integration.test.ts index 3a4d41089116..aa4be2432699 100644 --- a/packages/core/test/lib/integration.test.ts +++ b/packages/core/test/lib/integration.test.ts @@ -189,29 +189,6 @@ describe('getIntegrationsToSetup', () => { }); }); - describe('puts `Debug` integration last', () => { - // No variations here (default vs user, duplicates, user array vs user function, etc) because by the time we're - // dealing with the `Debug` integration, all of the combining and deduping has already been done - const noDebug = [new MockIntegration('ChaseSquirrels')]; - const debugNotLast = [new MockIntegration('Debug'), new MockIntegration('CatchTreats')]; - const debugAlreadyLast = [new MockIntegration('ChaseSquirrels'), new MockIntegration('Debug')]; - - const testCases: TestCase[] = [ - // each test case is [testName, defaultIntegrations, userIntegrations, expectedResult] - ['`Debug` not present', false, noDebug, ['ChaseSquirrels']], - ['`Debug` not originally last', false, debugNotLast, ['CatchTreats', 'Debug']], - ['`Debug` already last', false, debugAlreadyLast, ['ChaseSquirrels', 'Debug']], - ]; - - test.each(testCases)('%s', (_, defaultIntegrations, userIntegrations, expected) => { - const integrations = getIntegrationsToSetup({ - defaultIntegrations, - integrations: userIntegrations, - }); - expect(integrations.map(i => i.name)).toEqual(expected); - }); - }); - it('works with empty array', () => { const integrations = getIntegrationsToSetup({ integrations: [], @@ -305,29 +282,6 @@ describe('getIntegrationsToSetup', () => { expect((integrations[0] as any).order).toEqual('firstUser'); expect((integrations[1] as any).order).toEqual('secondUser'); }); - - it('always moves Debug integration to the end of the list', () => { - let integrations = getIntegrationsToSetup({ - defaultIntegrations: [new MockIntegration('Debug'), new MockIntegration('foo')], - integrations: [new MockIntegration('bar')], - }); - - expect(integrations.map(i => i.name)).toEqual(['foo', 'bar', 'Debug']); - - integrations = getIntegrationsToSetup({ - defaultIntegrations: [new MockIntegration('foo')], - integrations: [new MockIntegration('Debug'), new MockIntegration('bar')], - }); - - expect(integrations.map(i => i.name)).toEqual(['foo', 'bar', 'Debug']); - - integrations = getIntegrationsToSetup({ - defaultIntegrations: [new MockIntegration('Debug')], - integrations: [new MockIntegration('foo')], - }); - - expect(integrations.map(i => i.name)).toEqual(['foo', 'Debug']); - }); }); describe('setupIntegration', () => {