From 11fec21e4337cb81ea5bf1fc706c6ab1642eedee Mon Sep 17 00:00:00 2001 From: Conor O'Brien Date: Fri, 13 Dec 2024 16:05:18 +0000 Subject: [PATCH 1/2] feat(node): Detect Railway release name (#14691) This change adds release name detection for Railway Based on https://github.com/getsentry/sentry-javascript/pull/12529 Related: https://github.com/getsentry/sentry-javascript-bundler-plugins/pull/639 --- packages/node/src/sdk/api.ts | 2 ++ packages/vercel-edge/src/sdk.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/node/src/sdk/api.ts b/packages/node/src/sdk/api.ts index dd7ccc8ca75d..7e4f200d1e06 100644 --- a/packages/node/src/sdk/api.ts +++ b/packages/node/src/sdk/api.ts @@ -68,6 +68,8 @@ export function getSentryRelease(fallback?: string): string | undefined { process.env['HEROKU_TEST_RUN_COMMIT_VERSION'] || // Heroku #2 https://docs.sentry.io/product/integrations/deployment/heroku/#configure-releases process.env['HEROKU_SLUG_COMMIT'] || + // Railway - https://docs.railway.app/reference/variables#git-variables + process.env['RAILWAY_GIT_COMMIT_SHA'] || // Render - https://render.com/docs/environment-variables process.env['RENDER_GIT_COMMIT'] || // Semaphore CI - https://docs.semaphoreci.com/ci-cd-environment/environment-variables diff --git a/packages/vercel-edge/src/sdk.ts b/packages/vercel-edge/src/sdk.ts index 78f1f49ba092..c29e9f693ba2 100644 --- a/packages/vercel-edge/src/sdk.ts +++ b/packages/vercel-edge/src/sdk.ts @@ -268,6 +268,8 @@ export function getSentryRelease(fallback?: string): string | undefined { process.env['HEROKU_TEST_RUN_COMMIT_VERSION'] || // Heroku #2 https://docs.sentry.io/product/integrations/deployment/heroku/#configure-releases process.env['HEROKU_SLUG_COMMIT'] || + // Railway - https://docs.railway.app/reference/variables#git-variables + process.env['RAILWAY_GIT_COMMIT_SHA'] || // Render - https://render.com/docs/environment-variables process.env['RENDER_GIT_COMMIT'] || // Semaphore CI - https://docs.semaphoreci.com/ci-cd-environment/environment-variables From c24d002d80ca6e932ba197ea34ec48e9f3b0b88c Mon Sep 17 00:00:00 2001 From: AbhiPrasad <18689448+AbhiPrasad@users.noreply.github.com> Date: Fri, 13 Dec 2024 16:10:58 +0000 Subject: [PATCH 2/2] chore: Add external contributor to CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c3f0e52db2e6..810e75fee33b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott +Work in this release was contributed by @conor-ob. Thank you for your contribution! + ## 8.45.1 - fix(feedback): Return when the `sendFeedback` promise resolves ([#14683](https://github.com/getsentry/sentry-javascript/pull/14683))