From bb1c753ec37f198d20cc6180d3e68a48bb0ebbba Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 8 Oct 2024 18:35:36 -0400 Subject: [PATCH] feat(replay): Clear fallback buffer when switching buffers Saw this while debugging, this should not have a big effect since the fallback buffer should be relatively small. --- packages/replay-internal/src/eventBuffer/EventBufferProxy.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/replay-internal/src/eventBuffer/EventBufferProxy.ts b/packages/replay-internal/src/eventBuffer/EventBufferProxy.ts index 413bb6fb6372..ea81365b66a9 100644 --- a/packages/replay-internal/src/eventBuffer/EventBufferProxy.ts +++ b/packages/replay-internal/src/eventBuffer/EventBufferProxy.ts @@ -115,6 +115,9 @@ export class EventBufferProxy implements EventBuffer { // Wait for original events to be re-added before resolving try { await Promise.all(addEventPromises); + + // Can now clear fallback buffer as it's no longer necessary + this._fallback.clear(); } catch (error) { DEBUG_BUILD && logger.exception(error, 'Failed to add events when switching buffers.'); }