From f1f857e12badbc811e35be6820b3d26e748fff5d Mon Sep 17 00:00:00 2001
From: s1gr1d <sigrid.huemer@posteo.at>
Date: Mon, 23 Sep 2024 17:17:22 +0200
Subject: [PATCH 1/2] test(nuxt): Add E2E test for distributed tracing

---
 .../nuxt-3/pages/test-param/[param].vue       | 22 +++++---
 .../nuxt-3/tests/tracing.test.ts              | 51 +++++++++++++++++++
 2 files changed, 65 insertions(+), 8 deletions(-)
 create mode 100644 dev-packages/e2e-tests/test-applications/nuxt-3/tests/tracing.test.ts

diff --git a/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue b/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
index 379e8e417b35..6fa2ab0e0a4e 100644
--- a/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
+++ b/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
@@ -1,17 +1,23 @@
-<template>
-  <p>{{ $route.params.param }} - {{ $route.params.param }}</p>
-
-  <ErrorButton id="errorBtn" errorText="Error thrown from Param Route Button"  />
-  <button @click="fetchData">Fetch Server Data</button>
-</template>
-
 <script setup lang="ts">
 import { useRoute, useFetch } from '#imports'
 
 const route = useRoute();
 const param = route.params.param;
 
-const fetchData = async () => {
+const fetchError = async () => {
   await useFetch(`/api/param-error/${param}`);
 }
+
+const fetchData = async () => {
+  await useFetch(`/api/test-param/${param}`);
+};
 </script>
+
+<template>
+  <p>Param: {{ $route.params.param }}</p>
+
+  <ErrorButton id="errorBtn" errorText="Error thrown from Param Route Button"  />
+  <button @click="fetchData">Fetch Server Data</button>
+  <button @click="fetchError">Fetch Server Error</button>
+</template>
+
diff --git a/dev-packages/e2e-tests/test-applications/nuxt-3/tests/tracing.test.ts b/dev-packages/e2e-tests/test-applications/nuxt-3/tests/tracing.test.ts
new file mode 100644
index 000000000000..46e2b135a9b7
--- /dev/null
+++ b/dev-packages/e2e-tests/test-applications/nuxt-3/tests/tracing.test.ts
@@ -0,0 +1,51 @@
+import { expect, test } from '@playwright/test';
+import { waitForTransaction } from '@sentry-internal/test-utils';
+
+test.describe('distributed tracing', () => {
+  const PARAM = 's0me-param';
+
+  test('capture a distributed pageload trace', async ({ page }) => {
+    const clientTxnEventPromise = waitForTransaction('nuxt-3', txnEvent => {
+      return txnEvent.transaction === '/test-param/:param()';
+    });
+
+    const serverTxnEventPromise = waitForTransaction('nuxt-3', txnEvent => {
+      return txnEvent.transaction.includes('GET /test-param/');
+    });
+
+    const [_, clientTxnEvent, serverTxnEvent] = await Promise.all([
+      page.goto(`/test-param/${PARAM}`),
+      clientTxnEventPromise,
+      serverTxnEventPromise,
+      expect(page.getByText(`Param: ${PARAM}`)).toBeVisible(),
+    ]);
+
+    expect(clientTxnEvent).toMatchObject({
+      transaction: '/test-param/:param()',
+      transaction_info: { source: 'route' },
+      type: 'transaction',
+      contexts: {
+        trace: {
+          op: 'pageload',
+          origin: 'auto.pageload.vue',
+        },
+      },
+    });
+
+    expect(serverTxnEvent).toMatchObject({
+      transaction: 'GET /test-param/s0me-param', // todo: parametrize (nitro)
+      transaction_info: { source: 'url' },
+      type: 'transaction',
+      contexts: {
+        trace: {
+          op: 'http.server',
+          origin: 'auto.http.otel.http',
+        },
+      },
+    });
+
+    // connected trace
+    expect(clientTxnEvent.contexts?.trace?.trace_id).toBe(serverTxnEvent.contexts?.trace?.trace_id);
+    expect(clientTxnEvent.contexts?.trace?.parent_span_id).toBe(serverTxnEvent.contexts?.trace?.span_id);
+  });
+});

From 2efa2db89e99cdb8aee355da5103126e1cf8c9bd Mon Sep 17 00:00:00 2001
From: s1gr1d <sigrid.huemer@posteo.at>
Date: Thu, 26 Sep 2024 14:16:04 +0200
Subject: [PATCH 2/2] fix E2E test

---
 .../test-applications/nuxt-3/pages/test-param/[param].vue     | 2 +-
 .../test-applications/nuxt-3/tests/errors.server.test.ts      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue b/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
index 6fa2ab0e0a4e..e83392b37b5c 100644
--- a/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
+++ b/dev-packages/e2e-tests/test-applications/nuxt-3/pages/test-param/[param].vue
@@ -16,7 +16,7 @@ const fetchData = async () => {
 <template>
   <p>Param: {{ $route.params.param }}</p>
 
-  <ErrorButton id="errorBtn" errorText="Error thrown from Param Route Button"  />
+  <ErrorButton id="errorBtn" errorText="Error thrown from Param Route Button" />
   <button @click="fetchData">Fetch Server Data</button>
   <button @click="fetchError">Fetch Server Error</button>
 </template>
diff --git a/dev-packages/e2e-tests/test-applications/nuxt-3/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/nuxt-3/tests/errors.server.test.ts
index e9445d4c2382..d1556d511bf0 100644
--- a/dev-packages/e2e-tests/test-applications/nuxt-3/tests/errors.server.test.ts
+++ b/dev-packages/e2e-tests/test-applications/nuxt-3/tests/errors.server.test.ts
@@ -8,7 +8,7 @@ test.describe('server-side errors', async () => {
     });
 
     await page.goto(`/fetch-server-error`);
-    await page.getByText('Fetch Server Data').click();
+    await page.getByText('Fetch Server Data', { exact: true }).click();
 
     const error = await errorPromise;
 
@@ -26,7 +26,7 @@ test.describe('server-side errors', async () => {
     });
 
     await page.goto(`/test-param/1234`);
-    await page.getByText('Fetch Server Data').click();
+    await page.getByRole('button', { name: 'Fetch Server Error', exact: true }).click();
 
     const error = await errorPromise;