From 8240df26c77c31072146ccae9262fb0937705081 Mon Sep 17 00:00:00 2001 From: Catherine Lee <55311782+c298lee@users.noreply.github.com> Date: Tue, 25 Jun 2024 19:31:42 -0400 Subject: [PATCH 1/2] fix error message --- packages/feedback/src/core/sendFeedback.test.ts | 2 +- packages/feedback/src/core/sendFeedback.ts | 2 +- packages/feedback/src/modal/components/Dialog.css.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/feedback/src/core/sendFeedback.test.ts b/packages/feedback/src/core/sendFeedback.test.ts index 195c208b448a..5b4107d8fddb 100644 --- a/packages/feedback/src/core/sendFeedback.test.ts +++ b/packages/feedback/src/core/sendFeedback.test.ts @@ -275,7 +275,7 @@ describe('sendFeedback', () => { email: 're@example.org', message: 'mi', }), - ).rejects.toMatch('Unable to send Feedback. Invalid response from server.'); + ).rejects.toMatch('Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker'); }); it('handles 0 transport error', async () => { diff --git a/packages/feedback/src/core/sendFeedback.ts b/packages/feedback/src/core/sendFeedback.ts index a046111cc9ad..e55c792a29fb 100644 --- a/packages/feedback/src/core/sendFeedback.ts +++ b/packages/feedback/src/core/sendFeedback.ts @@ -63,7 +63,7 @@ export const sendFeedback: SendFeedback = ( ); } - return reject('Unable to send Feedback. Invalid response from server.'); + return reject('Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker'); }); }); }; diff --git a/packages/feedback/src/modal/components/Dialog.css.ts b/packages/feedback/src/modal/components/Dialog.css.ts index a9d1f4331606..48e2a05716c2 100644 --- a/packages/feedback/src/modal/components/Dialog.css.ts +++ b/packages/feedback/src/modal/components/Dialog.css.ts @@ -122,8 +122,8 @@ const FORM = ` } .form__error-container { - color: var(--error-foreground); - fill: var(--error-foreground); + color: var(--error-color); + fill: var(--error-color); } .form__label { From c614a6485bc6dd73270c4cc30aa9ecf67163b93c Mon Sep 17 00:00:00 2001 From: Catherine Lee <55311782+c298lee@users.noreply.github.com> Date: Tue, 25 Jun 2024 19:47:10 -0400 Subject: [PATCH 2/2] lint --- packages/feedback/src/core/sendFeedback.test.ts | 4 +++- packages/feedback/src/core/sendFeedback.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/feedback/src/core/sendFeedback.test.ts b/packages/feedback/src/core/sendFeedback.test.ts index 5b4107d8fddb..96df79828ac8 100644 --- a/packages/feedback/src/core/sendFeedback.test.ts +++ b/packages/feedback/src/core/sendFeedback.test.ts @@ -275,7 +275,9 @@ describe('sendFeedback', () => { email: 're@example.org', message: 'mi', }), - ).rejects.toMatch('Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker'); + ).rejects.toMatch( + 'Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker', + ); }); it('handles 0 transport error', async () => { diff --git a/packages/feedback/src/core/sendFeedback.ts b/packages/feedback/src/core/sendFeedback.ts index e55c792a29fb..3f8c08a51ee3 100644 --- a/packages/feedback/src/core/sendFeedback.ts +++ b/packages/feedback/src/core/sendFeedback.ts @@ -63,7 +63,9 @@ export const sendFeedback: SendFeedback = ( ); } - return reject('Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker'); + return reject( + 'Unable to send Feedback. This could be because of network issues, or because you are using an ad-blocker', + ); }); }); };