From fff2cc522e92ada681c33a0525ee014ef48aeccf Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 16 May 2024 14:58:50 +0200 Subject: [PATCH 1/2] ref(sveltekit): Emit warning if Sentry plugin enabled source maps generation --- packages/sveltekit/src/vite/sentryVitePlugins.ts | 4 ++++ packages/sveltekit/src/vite/sourceMaps.ts | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/sveltekit/src/vite/sentryVitePlugins.ts b/packages/sveltekit/src/vite/sentryVitePlugins.ts index 83a5cf4e19d6..59db8607fef7 100644 --- a/packages/sveltekit/src/vite/sentryVitePlugins.ts +++ b/packages/sveltekit/src/vite/sentryVitePlugins.ts @@ -239,6 +239,10 @@ export async function sentrySvelteKit(options: SentrySvelteKitPluginOptions = {} }; } + if (!sentryVitePluginsOptions.sourcemaps?.filesToDeleteAfterUpload) { + console.warn(''); + } + const sentryVitePlugins = await makeCustomSentryVitePlugins(sentryVitePluginsOptions); sentryPlugins.push(...sentryVitePlugins); diff --git a/packages/sveltekit/src/vite/sourceMaps.ts b/packages/sveltekit/src/vite/sourceMaps.ts index eb97a3e4a7c6..5b9e2d355cfa 100644 --- a/packages/sveltekit/src/vite/sourceMaps.ts +++ b/packages/sveltekit/src/vite/sourceMaps.ts @@ -103,8 +103,18 @@ export async function makeCustomSentryVitePlugins(options?: CustomSentryVitePlug // Modify the config to generate source maps config: config => { - // eslint-disable-next-line no-console - debug && console.log('[Source Maps Plugin] Enabeling source map generation'); + const sourceMapsPreviouslyEnabled = !config.build?.sourcemap; + if (debug && sourceMapsPreviouslyEnabled) { + // eslint-disable-next-line no-console + console.log('[Source Maps Plugin] Enabeling source map generation'); + if (!mergedOptions.sourcemaps?.filesToDeleteAfterUpload) { + // eslint-disable-next-line no-console + console.warn( + `[Source Maps Plugin] We recommend setting the \`sourceMapsUploadOptions.sourcemaps.filesToDeleteAfterUpload\` option to clean up source maps after uploading. +[Source Maps Plugin] Otherwise, source maps might be deployed to production, depending on your configuration`, + ); + } + } return { ...config, build: { From 545028014844abd935494761f05b6080c0a38670 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 16 May 2024 15:00:13 +0200 Subject: [PATCH 2/2] cleanup --- packages/sveltekit/src/vite/sentryVitePlugins.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/sveltekit/src/vite/sentryVitePlugins.ts b/packages/sveltekit/src/vite/sentryVitePlugins.ts index 59db8607fef7..83a5cf4e19d6 100644 --- a/packages/sveltekit/src/vite/sentryVitePlugins.ts +++ b/packages/sveltekit/src/vite/sentryVitePlugins.ts @@ -239,10 +239,6 @@ export async function sentrySvelteKit(options: SentrySvelteKitPluginOptions = {} }; } - if (!sentryVitePluginsOptions.sourcemaps?.filesToDeleteAfterUpload) { - console.warn(''); - } - const sentryVitePlugins = await makeCustomSentryVitePlugins(sentryVitePluginsOptions); sentryPlugins.push(...sentryVitePlugins);