From ebdcbc168ee259455d73d9f7536f99c46e0f12aa Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Fri, 10 May 2024 13:02:10 +0200 Subject: [PATCH 1/3] feat(node): Log process and thread info on initialisation --- packages/node/src/sdk/client.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/node/src/sdk/client.ts b/packages/node/src/sdk/client.ts index b2d23ea31cc2..d7e3b674713b 100644 --- a/packages/node/src/sdk/client.ts +++ b/packages/node/src/sdk/client.ts @@ -1,9 +1,11 @@ +import { isMainThread, threadId } from 'node:worker_threads'; import * as os from 'os'; import type { Tracer } from '@opentelemetry/api'; import { trace } from '@opentelemetry/api'; import type { BasicTracerProvider } from '@opentelemetry/sdk-trace-base'; import type { ServerRuntimeClientOptions } from '@sentry/core'; import { SDK_VERSION, ServerRuntimeClient, applySdkMetadata } from '@sentry/core'; +import { logger } from '@sentry/utils'; import type { NodeClientOptions } from '../types'; /** A client for using Sentry with Node & OpenTelemetry. */ @@ -21,6 +23,8 @@ export class NodeClient extends ServerRuntimeClient { applySdkMetadata(clientOptions, 'node'); + logger.log(`Initializing Sentry, pid: ${process.pid}, thread: ${isMainThread ? 'main' : `worker-${threadId}`}.`); + super(clientOptions); } From 32ec454713512de6ee68a5eb4aefcb246f6c5969 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Fri, 10 May 2024 13:14:50 +0200 Subject: [PATCH 2/3] tidy format --- packages/node/src/sdk/client.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/node/src/sdk/client.ts b/packages/node/src/sdk/client.ts index d7e3b674713b..cec7404704ea 100644 --- a/packages/node/src/sdk/client.ts +++ b/packages/node/src/sdk/client.ts @@ -23,7 +23,9 @@ export class NodeClient extends ServerRuntimeClient { applySdkMetadata(clientOptions, 'node'); - logger.log(`Initializing Sentry, pid: ${process.pid}, thread: ${isMainThread ? 'main' : `worker-${threadId}`}.`); + logger.log( + `Initializing Sentry: process: ${process.pid}, thread: ${isMainThread ? 'main' : `worker-${threadId}`}.`, + ); super(clientOptions); } From 9b924a612497afb3a60ff337ed5383011a740cc3 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Fri, 10 May 2024 13:30:33 +0200 Subject: [PATCH 3/3] dont use node:worker_threads for now --- packages/node/src/sdk/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/src/sdk/client.ts b/packages/node/src/sdk/client.ts index cec7404704ea..8658ebf3e918 100644 --- a/packages/node/src/sdk/client.ts +++ b/packages/node/src/sdk/client.ts @@ -1,4 +1,3 @@ -import { isMainThread, threadId } from 'node:worker_threads'; import * as os from 'os'; import type { Tracer } from '@opentelemetry/api'; import { trace } from '@opentelemetry/api'; @@ -6,6 +5,7 @@ import type { BasicTracerProvider } from '@opentelemetry/sdk-trace-base'; import type { ServerRuntimeClientOptions } from '@sentry/core'; import { SDK_VERSION, ServerRuntimeClient, applySdkMetadata } from '@sentry/core'; import { logger } from '@sentry/utils'; +import { isMainThread, threadId } from 'worker_threads'; import type { NodeClientOptions } from '../types'; /** A client for using Sentry with Node & OpenTelemetry. */