From cda499423d06a981b973045db7040924953f2653 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Sat, 13 Apr 2024 11:54:13 +0200 Subject: [PATCH 1/2] fix(node): Use `NodeClient` without calling `init` --- packages/node/src/index.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/node/src/index.ts b/packages/node/src/index.ts index ee037c6fdc8b..1ece2f0d81b0 100644 --- a/packages/node/src/index.ts +++ b/packages/node/src/index.ts @@ -37,9 +37,13 @@ export type { NodeOptions } from './types'; export { addRequestDataToEvent, DEFAULT_USER_INCLUDES, extractRequestData } from '@sentry/utils'; -// These are custom variants that need to be used instead of the core one -// As they have slightly different implementations -export { continueTrace } from '@sentry/opentelemetry'; +export { + // These are custom variants that need to be used instead of the core one + // As they have slightly different implementations + continueTrace, + // This needs exporting so the NodeClient can be used without calling init + setOpenTelemetryContextAsyncContextStrategy as setNodeAsyncContextStrategy, +} from '@sentry/opentelemetry'; export { addBreadcrumb, From 6d2623222e18ef030f866c1852365c80f315ad8b Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Sat, 13 Apr 2024 12:11:44 +0200 Subject: [PATCH 2/2] Exclude from required exports --- .../node-exports-test-app/scripts/consistentExports.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts b/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts index 0aceb4418ddc..914b569f978e 100644 --- a/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts +++ b/dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts @@ -14,6 +14,8 @@ const NODE_EXPORTS_IGNORE = [ 'default', // Probably generated by transpilation, no need to require it '__esModule', + // Only required from the Node package + 'setNodeAsyncContextStrategy', ]; const nodeExports = Object.keys(SentryNode).filter(e => !NODE_EXPORTS_IGNORE.includes(e));