From bcded3a0fd566771e1479fb13018e3542f870f36 Mon Sep 17 00:00:00 2001 From: Edem Kojo Agbakpe Date: Wed, 6 Mar 2024 15:29:56 +0000 Subject: [PATCH 1/2] feat(node): untrue comment in source code #9211 --- packages/node/src/integrations/http.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts index 00858d6b15cf..a4b6b07193cb 100644 --- a/packages/node/src/integrations/http.ts +++ b/packages/node/src/integrations/http.ts @@ -138,8 +138,10 @@ const _httpIntegration = ((options: HttpIntegrationOptions = {}) => { export const httpIntegration = defineIntegration(_httpIntegration); /** - * The http module integration instruments Node's internal http module. It creates breadcrumbs, transactions for outgoing - * http requests and attaches trace data when tracing is enabled via its `tracing` option. + * The http module integration instruments Node's internal http module. + * It creates breadcrumbs for outgoing HTTP requests. + * It also creates spans for outgoing HTTP requests, which can be attached to a manually created transaction. + * It does not automatically create a transaction for each outgoing HTTP request. * * @deprecated Use `httpIntegration()` instead. */ From 2b853674d506d4f04752425146f0473e53c42375 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 7 Mar 2024 09:57:12 +0000 Subject: [PATCH 2/2] Reword a bit and add description to new integration --- packages/node-experimental/src/integrations/http.ts | 4 ++++ packages/node/src/integrations/http.ts | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/node-experimental/src/integrations/http.ts b/packages/node-experimental/src/integrations/http.ts index 0c53a0c7e889..be903c00326d 100644 --- a/packages/node-experimental/src/integrations/http.ts +++ b/packages/node-experimental/src/integrations/http.ts @@ -117,6 +117,10 @@ const _httpIntegration = ((options: HttpOptions = {}) => { }; }) satisfies IntegrationFn; +/** + * The http integration instruments Node's internal http and https modules. + * It creates breadcrumbs and spans for outgoing HTTP requests which will be attached to the currently active span. + */ export const httpIntegration = defineIntegration(_httpIntegration); /** Update the span with data we need. */ diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts index a4b6b07193cb..75dc8e061537 100644 --- a/packages/node/src/integrations/http.ts +++ b/packages/node/src/integrations/http.ts @@ -138,10 +138,8 @@ const _httpIntegration = ((options: HttpIntegrationOptions = {}) => { export const httpIntegration = defineIntegration(_httpIntegration); /** - * The http module integration instruments Node's internal http module. - * It creates breadcrumbs for outgoing HTTP requests. - * It also creates spans for outgoing HTTP requests, which can be attached to a manually created transaction. - * It does not automatically create a transaction for each outgoing HTTP request. + * The http integration instruments Node's internal http and https modules. + * It creates breadcrumbs and spans for outgoing HTTP requests which will be attached to the currently active span. * * @deprecated Use `httpIntegration()` instead. */