Adjust span names to say "(partial render tree)" instead of "RSC" for RSC requests #69728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
RSC
prefix from OpenTelemetry span names for "RSC Requests". From my understanding RSC Requests in the code base are requests that are made as part of a navigation in app router, requesting an RSC payload.Why?
This should probably be changed because a) it does not follow the Semantic OpenTelemetry conventions (https://opentelemetry.io/docs/specs/semconv/http/http-spans/#name) b) it causes grouping issues with other RSC requests that are non navigational, like prefetch requests, and initial pageloads/hard-navigations.
The original PR that added this prefix does not contain a description so I may lack some background info as to why the prefix was introduced in the first place: #62464
In my opinion, it is not clear to downstream users what the "RSC" prefix actually means, so it is fine to remove. I am happy to learn something different though!
How?
Right now this PR simply updates the name. In theory, no data is lost because the fact whether the request was an "RSC request" by the definition above is still stored as a
next.rsc
span attribute.Relates to #64723
Fixes getsentry/sentry-javascript#13597