Skip to content

Commit f2a777a

Browse files
authored
chore: Bump volta to node 20 (#15315)
1 parent e10db30 commit f2a777a

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"yalc:publish": "lerna run yalc:publish"
4646
},
4747
"volta": {
48-
"node": "18.20.5",
48+
"node": "20.18.2",
4949
"yarn": "1.22.22",
5050
"pnpm": "9.15.0"
5151
},

packages/browser/src/eventbuilder.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,14 @@ export function extractType(ex: Error & { message: { error?: Error } }): string
199199
export function extractMessage(ex: Error & { message: { error?: Error } }): string {
200200
const message = ex?.message;
201201

202+
if (isWebAssemblyException(ex)) {
203+
// For Node 18, Emscripten sets array[type, message] to the "message" property on the WebAssembly.Exception object
204+
if (Array.isArray(ex.message) && ex.message.length == 2) {
205+
return ex.message[1];
206+
}
207+
return 'wasm exception';
208+
}
209+
202210
if (!message) {
203211
return 'No error message';
204212
}
@@ -207,11 +215,6 @@ export function extractMessage(ex: Error & { message: { error?: Error } }): stri
207215
return message.error.message;
208216
}
209217

210-
// Emscripten sets array[type, message] to the "message" property on the WebAssembly.Exception object
211-
if (isWebAssemblyException(ex) && Array.isArray(ex.message) && ex.message.length == 2) {
212-
return ex.message[1];
213-
}
214-
215218
return message;
216219
}
217220

0 commit comments

Comments
 (0)