fix various linter errors

Author: Lms24

packages/sveltekit/.eslintrc.js

@@ -18,8 +18,10 @@ module.exports = {
       },
     },
     {
-      files: ['./src/vite/**', './src/server/**'],
-      '@sentry-internal/sdk/no-optional-chaining': 'off',
+      files: ['src/vite/**', 'src/server/**'],
+      rules: {
+        '@sentry-internal/sdk/no-optional-chaining': 'off',
+      },
     },
   ],
   extends: ['../../.eslintrc.js'],

packages/sveltekit/src/server/utils.ts

@@ -65,7 +65,7 @@ export function rewriteFramesIteratee(frame: StackFrame): StackFrame {
 
     let strippedFilename;
     if (svelteKitBuildOutDir) {
-      strippedFilename = filename.replace(new RegExp(`^.*${escapeStringForRegex(svelteKitBuildOutDir)}\/server\/`), '');
+      strippedFilename = filename.replace(new RegExp(`^.*${escapeStringForRegex(svelteKitBuildOutDir)}/server/`), '');
     } else {
       strippedFilename = basename(filename);
     }

packages/sveltekit/src/vite/sourceMaps.ts

@@ -72,7 +72,7 @@ export async function makeCustomSentryVitePlugin(options?: CustomSentryVitePlugi
   const sentryPlugin: Plugin = sentryVitePlugin(mergedOptions);
 
   const { debug } = mergedOptions;
-  const { buildStart, resolveId, transform, renderChunk } = sentryPlugin;
+  const { buildStart, resolveId, renderChunk } = sentryPlugin;
 
   let isSSRBuild = true;
 
@@ -114,10 +114,10 @@ export async function makeCustomSentryVitePlugin(options?: CustomSentryVitePlugi
 
     transform: async (code, id) => {
       let modifiedCode = code;
-      const isServerHooksFile = new RegExp(`\/${escapeStringForRegex(serverHooksFile)}(.(js|ts|mjs|mts))?`).test(id);
+      const isServerHooksFile = new RegExp(`/${escapeStringForRegex(serverHooksFile)}(.(js|ts|mjs|mts))?`).test(id);
 
       if (isServerHooksFile) {
-        let injectedCode = `global.__sentry_sveltekit_output_dir = "${outputDir || 'undefined'}";\n`;
+        const injectedCode = `global.__sentry_sveltekit_output_dir = "${outputDir || 'undefined'}";\n`;
         modifiedCode = `${code}\n${injectedCode}`;
       }
       // @ts-ignore - this hook exists on the plugin!

packages/sveltekit/src/vite/svelteConfig.ts

@@ -4,7 +4,8 @@ import type { Builder, Config } from '@sveltejs/kit';
 import * as fs from 'fs';
 import * as path from 'path';
 import * as url from 'url';
-import { SupportedSvelteKitAdapters } from './detectAdapter';
+
+import type { SupportedSvelteKitAdapters } from './detectAdapter';
 
 /**
  * Imports the svelte.config.js file and returns the config object.
@@ -40,7 +41,7 @@ export async function loadSvelteConfig(): Promise<Config> {
  * Reads a custom hooks directory from the SvelteKit config. In case no custom hooks
  * directory is specified, the default directory is returned.
  */
-export function getHooksFileName(svelteConfig: Config, hookType: 'client' | 'server') {
+export function getHooksFileName(svelteConfig: Config, hookType: 'client' | 'server'): string {
   return svelteConfig.kit?.files?.hooks?.[hookType] || `src/hooks.${hookType}`;
 }
 

packages/sveltekit/test/server/utils.test.ts

@@ -2,7 +2,8 @@ import { RewriteFrames } from '@sentry/integrations';
 import type { StackFrame } from '@sentry/types';
 import { basename } from '@sentry/utils';
 
-import { getTracePropagationData, GlobalWithSentryValues, rewriteFramesIteratee } from '../../src/server/utils';
+import type { GlobalWithSentryValues } from '../../src/server/utils';
+import { getTracePropagationData, rewriteFramesIteratee } from '../../src/server/utils';
 
 const MOCK_REQUEST_EVENT: any = {
   request: {
@@ -107,7 +108,7 @@ describe('rewriteFramesIteratee', () => {
   ])(
     'removes the absolut path to the server output dir, if the output dir is available (%s)',
     (_, outputDir, frameFilename, modifiedFilename) => {
-      (global as GlobalWithSentryValues).__sentry_sveltekit_output_dir = outputDir;
+      (globalThis as GlobalWithSentryValues).__sentry_sveltekit_output_dir = outputDir;
 
       const frame: StackFrame = {
         filename: frameFilename,
@@ -124,7 +125,7 @@ describe('rewriteFramesIteratee', () => {
         colno: 1,
       });
 
-      delete (global as GlobalWithSentryValues).__sentry_sveltekit_output_dir;
+      delete (globalThis as GlobalWithSentryValues).__sentry_sveltekit_output_dir;
     },
   );
 });

packages/sveltekit/test/vite/svelteConfig.test.ts

@@ -1,6 +1,6 @@
 import { vi } from 'vitest';
-import { SupportedSvelteKitAdapters } from '../../src/vite/detectAdapter';
 
+import type { SupportedSvelteKitAdapters } from '../../src/vite/detectAdapter';
 import { getAdapterOutputDir, getHooksFileName, loadSvelteConfig } from '../../src/vite/svelteConfig';
 
 let existsFile;