Skip to content

Commit d1323e9

Browse files
committed
fix for webkit integration test run
1 parent 21f87da commit d1323e9

File tree

1 file changed

+15
-7
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans

1 file changed

+15
-7
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ import { type Event, SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORI
55
import { sentryTest } from '../../../../utils/fixtures';
66
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
77

8-
sentryTest('should add resource spans to pageload transaction', async ({ getLocalTestUrl, page }) => {
8+
sentryTest('should add resource spans to pageload transaction', async ({ getLocalTestUrl, page, browserName }) => {
99
if (shouldSkipTracingTest()) {
1010
sentryTest.skip();
1111
}
1212

13+
const isWebkitRun = browserName === 'webkit';
14+
1315
// Intercepting asset requests to avoid network-related flakiness and random retries (on Firefox).
1416
await page.route('https://example.com/path/to/image.svg', (route: Route) =>
1517
route.fulfill({
@@ -72,16 +74,18 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
7274
data: {
7375
'http.decoded_response_content_length': expect.any(Number),
7476
'http.response_content_length': expect.any(Number),
75-
'http.response_delivery_type': '',
7677
'http.response_transfer_size': expect.any(Number),
7778
'network.protocol.name': '',
7879
'network.protocol.version': 'unknown',
79-
'resource.render_blocking_status': 'non-blocking',
8080
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.img',
8181
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
8282
'server.address': 'example.com',
8383
'url.same_origin': false,
8484
'url.scheme': 'https',
85+
...(!isWebkitRun && {
86+
'resource.render_blocking_status': 'non-blocking',
87+
'http.response_delivery_type': '',
88+
}),
8589
},
8690
description: 'https://example.com/path/to/image.svg',
8791
op: 'resource.img',
@@ -97,16 +101,18 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
97101
data: {
98102
'http.decoded_response_content_length': expect.any(Number),
99103
'http.response_content_length': expect.any(Number),
100-
'http.response_delivery_type': '',
101104
'http.response_transfer_size': expect.any(Number),
102105
'network.protocol.name': '',
103106
'network.protocol.version': 'unknown',
104-
'resource.render_blocking_status': 'non-blocking',
105107
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.link',
106108
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
107109
'server.address': 'example.com',
108110
'url.same_origin': false,
109111
'url.scheme': 'https',
112+
...(!isWebkitRun && {
113+
'resource.render_blocking_status': 'non-blocking',
114+
'http.response_delivery_type': '',
115+
}),
110116
},
111117
description: 'https://example.com/path/to/style.css',
112118
op: 'resource.link',
@@ -122,16 +128,18 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
122128
data: {
123129
'http.decoded_response_content_length': expect.any(Number),
124130
'http.response_content_length': expect.any(Number),
125-
'http.response_delivery_type': '',
126131
'http.response_transfer_size': expect.any(Number),
127132
'network.protocol.name': '',
128133
'network.protocol.version': 'unknown',
129-
'resource.render_blocking_status': 'non-blocking',
130134
'sentry.op': 'resource.script',
131135
'sentry.origin': 'auto.resource.browser.metrics',
132136
'server.address': 'example.com',
133137
'url.same_origin': false,
134138
'url.scheme': 'https',
139+
...(!isWebkitRun && {
140+
'resource.render_blocking_status': 'non-blocking',
141+
'http.response_delivery_type': '',
142+
}),
135143
},
136144
description: 'https://example.com/path/to/script.js',
137145
op: 'resource.script',

0 commit comments

Comments
 (0)