feat(build)!: Drop polyfills & bump ES target to ES2020

mydea · mydea · commit ce0893ba1a1b · 2025-01-02T10:57:52.000+01:00
diff --git a/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/default-browser/tsconfig.json b/dev-packages/e2e-tests/test-applications/default-browser/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json b/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json
@@ -1,11 +1,11 @@
 {
   "include": ["index.ts"],
   "compilerOptions": {
-    "lib": ["es2018", "DOM"],
+    "lib": ["ES2020", "DOM"],
     "skipLibCheck": false,
     "noEmit": true,
     "types": [],
-    "target": "es2018",
+    "target": "ES2020",
     "moduleResolution": "node"
   }
 }
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-13/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-13/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-15/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-15/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-turbo/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-turbo/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist",
     "target": "ESNext",
diff --git a/dev-packages/e2e-tests/test-applications/node-express-incorrect-instrumentation/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-express-incorrect-instrumentation/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-express-send-to-sentry/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-express-send-to-sentry/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-otel-sdk-node/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-otel-sdk-node/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-otel-without-tracing/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-otel-without-tracing/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018", "dom"],
+    "lib": ["ES2020", "dom"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-otel/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-otel/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist"
   },
diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-profiling/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "types": ["node"],
     "esModuleInterop": true,
-    "lib": ["es2018"],
+    "lib": ["ES2020"],
     "strict": true,
     "outDir": "dist",
     "target": "ESNext",
diff --git a/dev-packages/e2e-tests/test-applications/react-17/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-17/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-19/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-19/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-router-5/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-5/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-router-6-descendant-routes/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-6-descendant-routes/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-router-6/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-6/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-router-7-spa/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-7-spa/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/e2e-tests/test-applications/react-send-to-sentry/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-send-to-sentry/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "lib": ["dom", "dom.iterable", "esnext"],
     "allowJs": true,
     "skipLibCheck": true,
diff --git a/dev-packages/node-integration-tests/suites/tsconfig.json b/dev-packages/node-integration-tests/suites/tsconfig.json
@@ -4,6 +4,6 @@
   "compilerOptions": {
     // Although this seems wrong to include `DOM` here, it's necessary to make
     // global fetch available in tests in lower Node versions.
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
   }
 }
diff --git a/dev-packages/node-integration-tests/tsconfig.json b/dev-packages/node-integration-tests/tsconfig.json
@@ -6,7 +6,7 @@
   "compilerOptions": {
     // Although this seems wrong to include `DOM` here, it's necessary to make
     // global fetch available in tests in lower Node versions.
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
     // package-specific options
     "esModuleInterop": true,
     "types": ["node", "jest"]
diff --git a/dev-packages/node-integration-tests/tsconfig.test.json b/dev-packages/node-integration-tests/tsconfig.test.json
@@ -6,7 +6,7 @@
   "compilerOptions": {
     // Although this seems wrong to include `DOM` here, it's necessary to make
     // global fetch available in tests in lower Node versions.
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
     // should include all types from `./tsconfig.json` plus types for all test frameworks used
     "types": ["node", "jest"]
 
diff --git a/dev-packages/rollup-utils/npmHelpers.mjs b/dev-packages/rollup-utils/npmHelpers.mjs
@@ -33,13 +33,12 @@ export function makeBaseNPMConfig(options = {}) {
     esModuleInterop = false,
     hasBundles = false,
     packageSpecificConfig = {},
-    addPolyfills = true,
     sucrase = {},
     bundledBuiltins = [],
   } = options;
 
   const nodeResolvePlugin = makeNodeResolvePlugin();
-  const sucrasePlugin = makeSucrasePlugin({}, { disableESTransforms: !addPolyfills, ...sucrase });
+  const sucrasePlugin = makeSucrasePlugin({}, { disableESTransforms: true, ...sucrase });
   const debugBuildStatementReplacePlugin = makeDebugBuildStatementReplacePlugin();
   const importMetaUrlReplacePlugin = makeImportMetaUrlReplacePlugin();
   const cleanupPlugin = makeCleanupPlugin();
@@ -69,8 +68,7 @@ export function makeBaseNPMConfig(options = {}) {
       // true` in CJS modules makes it so that Jest <= 29.2.2 crashes when trying to mock generated `@sentry/xxx`
       // packages. See https://github.com/getsentry/sentry-javascript/pull/6043.)
       generatedCode: {
-        preset: 'es2015',
-        symbols: false,
+        preset: 'es2015'
       },
 
       // don't add `"use strict"` to the top of cjs files
diff --git a/packages/angular/tsconfig.ngc.json b/packages/angular/tsconfig.ngc.json
@@ -5,9 +5,9 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "target": "es2018",
+    "target": "ES2020",
     "declarationMap": false,
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
     "baseUrl": "./"
   },
   "angularCompilerOptions": {
diff --git a/packages/astro/rollup.npm.config.mjs b/packages/astro/rollup.npm.config.mjs
@@ -9,8 +9,6 @@ const variants = makeNPMConfigVariants(
         exports: 'named',
       },
     },
-    // Astro is Node 18+ no need to add polyfills
-    addPolyfills: false,
   }),
 );
 
diff --git a/packages/aws-serverless/tsconfig.json b/packages/aws-serverless/tsconfig.json
@@ -5,7 +5,7 @@
 
   "compilerOptions": {
     // package-specific options
-    "target": "ES2018",
+    "target": "ES2020",
     "resolveJsonModule": true
   }
 }
diff --git a/packages/browser-utils/tsconfig.json b/packages/browser-utils/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
   }
 }
diff --git a/packages/browser/src/client.ts b/packages/browser/src/client.ts
@@ -106,7 +106,10 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
    * @inheritDoc
    */
   protected _prepareEvent(event: Event, hint: EventHint, scope?: Scope): PromiseLike<Event | null> {
-    event.platform = event.platform || 'javascript';
+    event.platform = event?.platform || 'javascript';
+
+
+
     return super._prepareEvent(event, hint, scope);
   }
 }
diff --git a/packages/browser/tsconfig.json b/packages/browser/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*", "test/loader.js"],
 
   "compilerOptions": {
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
   }
 }
diff --git a/packages/core/tsconfig.test.json b/packages/core/tsconfig.test.json
@@ -4,7 +4,7 @@
   "include": ["test/**/*"],
 
   "compilerOptions": {
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
     // should include all types from `./tsconfig.json` plus types for all test frameworks used
     "types": ["node", "jest"]
 
diff --git a/packages/eslint-config-sdk/src/base.js b/packages/eslint-config-sdk/src/base.js
@@ -52,6 +52,8 @@ module.exports = {
 
         '@typescript-eslint/consistent-type-imports': 'error',
 
+        '@typescript-eslint/no-unnecessary-condition': 'error',
+
         // Private and protected members of a class should be prefixed with a leading underscore.
         // typeLike declarations (class, interface, typeAlias, enum, typeParameter) should be
         // PascalCase.
diff --git a/packages/gatsby/tsconfig.json b/packages/gatsby/tsconfig.json
@@ -4,7 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["DOM", "ES2018"],
+    "lib": ["DOM", "ES2020"],
     // package-specific options
     "jsx": "react"
   }
diff --git a/packages/google-cloud-serverless/tsconfig.json b/packages/google-cloud-serverless/tsconfig.json
@@ -5,7 +5,7 @@
 
   "compilerOptions": {
     // package-specific options
-    "target": "ES2018",
+    "target": "ES2020",
     "resolveJsonModule": true
   }
 }
diff --git a/packages/nitro-utils/tsconfig.json b/packages/nitro-utils/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["ES2018"],
+    "lib": ["ES2020"],
   }
 }
diff --git a/packages/node/tsconfig.json b/packages/node/tsconfig.json
@@ -4,7 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["es2018", "es2020.string"],
+    "lib": ["ES2020", "es2020.string"],
     "module": "Node16"
   }
 }
diff --git a/packages/profiling-node/tsconfig.json b/packages/profiling-node/tsconfig.json
diff --git a/packages/react/tsconfig.json b/packages/react/tsconfig.json
diff --git a/packages/remix/tsconfig.test.json b/packages/remix/tsconfig.test.json
diff --git a/packages/replay-canvas/tsconfig.json b/packages/replay-canvas/tsconfig.json
diff --git a/packages/replay-canvas/tsconfig.test.json b/packages/replay-canvas/tsconfig.test.json
diff --git a/packages/replay-internal/tsconfig.json b/packages/replay-internal/tsconfig.json
diff --git a/packages/replay-worker/tsconfig.json b/packages/replay-worker/tsconfig.json
diff --git a/packages/solid/tsconfig.json b/packages/solid/tsconfig.json
diff --git a/packages/svelte/tsconfig.json b/packages/svelte/tsconfig.json
diff --git a/packages/types/tsconfig.json b/packages/types/tsconfig.json
diff --git a/packages/typescript/tsconfig.json b/packages/typescript/tsconfig.json
diff --git a/packages/vercel-edge/tsconfig.json b/packages/vercel-edge/tsconfig.json
diff --git a/packages/vue/tsconfig.json b/packages/vue/tsconfig.json
diff --git a/packages/wasm/tsconfig.json b/packages/wasm/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`		`- "target": "es2018",`
	`3`	`+ "target": "ES2020",`
`4`	`4`	`"lib": ["dom", "dom.iterable", "esnext"],`
`5`	`5`	`"allowJs": true,`
`6`	`6`	`"skipLibCheck": true,`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	`{`
`2`	`2`	`"include": ["index.ts"],`
`3`	`3`	`"compilerOptions": {`
`4`		`- "lib": ["es2018", "DOM"],`
	`4`	`+ "lib": ["ES2020", "DOM"],`
`5`	`5`	`"skipLibCheck": false,`
`6`	`6`	`"noEmit": true,`
`7`	`7`	`"types": [],`
`8`		`- "target": "es2018",`
	`8`	`+ "target": "ES2020",`
`9`	`9`	`"moduleResolution": "node"`
`10`	`10`	`}`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"compilerOptions": {`
`5`	`5`	// Although this seems wrong to include `DOM` here, it's necessary to make
`6`	`6`	`// global fetch available in tests in lower Node versions.`
`7`		`- "lib": ["DOM", "ES2018"],`
	`7`	`+ "lib": ["DOM", "ES2020"],`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`	`7`	`// package-specific options`
`8`		`- "target": "ES2018",`
	`8`	`+ "target": "ES2020",`
`9`	`9`	`"resolveJsonModule": true`
`10`	`10`	`}`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"include": ["src/*/"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`		`- "lib": ["DOM", "ES2018"],`
	`7`	`+ "lib": ["DOM", "ES2020"],`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,10 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {`
`106`	`106`	`* @inheritDoc`
`107`	`107`	`*/`
`108`	`108`	`protected _prepareEvent(event: Event, hint: EventHint, scope?: Scope): PromiseLike<Event \| null> {`
`109`		`- event.platform = event.platform \|\| 'javascript';`
	`109`	`+ event.platform = event?.platform \|\| 'javascript';`
	`110`	`+`
	`111`	`+`
	`112`	`+`
`110`	`113`	`return super._prepareEvent(event, hint, scope);`
`111`	`114`	`}`
`112`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"include": ["src/*/", "test/loader.js"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`		`- "lib": ["DOM", "ES2018"],`
	`7`	`+ "lib": ["DOM", "ES2020"],`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`"include": ["src/*/"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`		`- "lib": ["DOM", "ES2018"],`
	`7`	`+ "lib": ["DOM", "ES2020"],`
`8`	`8`	`// package-specific options`
`9`	`9`	`"jsx": "react"`
`10`	`10`	`}`