Skip to content

Commit c79a1a1

Browse files
committed
we do need it for RN
1 parent c9c5646 commit c79a1a1

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

packages/core/src/carrier.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ export interface SentryCarrier {
2727
globalMetricsAggregators?: WeakMap<Client, MetricsAggregator> | undefined;
2828
logger?: Logger;
2929

30-
// TODO(v9): Do we still need those?
31-
// --> Check with RN
3230
/** Overwrites TextEncoder used in `@sentry/core`, need for `react-native@0.73` and older */
3331
encodePolyfill?: (input: string) => Uint8Array;
3432
/** Overwrites TextDecoder used in `@sentry/core`, need for `react-native@0.73` and older */

packages/core/src/utils-hoist/envelope.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ export function envelopeContainsItemType(envelope: Envelope, types: EnvelopeItem
7575
* Encode a string to UTF8 array.
7676
*/
7777
function encodeUTF8(input: string): Uint8Array {
78-
// TODO(v9): Do we actually still need this?
79-
// --> Evaluate if RN still needs this
8078
const carrier = getSentryCarrier(GLOBAL_OBJ);
8179
return carrier.encodePolyfill ? carrier.encodePolyfill(input) : new TextEncoder().encode(input);
8280
}
@@ -85,8 +83,6 @@ function encodeUTF8(input: string): Uint8Array {
8583
* Decode a UTF8 array to string.
8684
*/
8785
function decodeUTF8(input: Uint8Array): string {
88-
// TODO(v9): Do we actually still need this?
89-
// --> Evaluate if RN still needs this
9086
const carrier = getSentryCarrier(GLOBAL_OBJ);
9187
return carrier.decodePolyfill ? carrier.decodePolyfill(input) : new TextDecoder().decode(input);
9288
}

0 commit comments

Comments
 (0)