Merge remote-tracking branch 'upstream/develop' into feat/node-use-ServerRuntimeClient

Author: timfish

.github/workflows/build.yml

@@ -818,7 +818,7 @@ jobs:
       - name: Set up Node
         uses: actions/setup-node@v3
         with:
-          node-version-file: 'package.json'
+          node-version-file: 'packages/e2e-tests/package.json'
       - name: Restore caches
         uses: ./.github/actions/restore-cache
         env:
@@ -833,7 +833,7 @@ jobs:
       - name: Get node version
         id: versions
         run: |
-          echo "echo node=$(jq -r '.volta.node' package.json)" >> $GITHUB_OUTPUT
+          echo "echo node=$(jq -r '.volta.node' packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT
 
       - name: Validate Verdaccio
         run: yarn test:validate

.npmignore

@@ -6,3 +6,4 @@
 !/cjs/**/*
 !/esm/**/*
 !/types/**/*
+!/types-ts3.8/**/*

CHANGELOG.md

@@ -4,6 +4,52 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.68.0
+
+- feat(browser): Add `BroadcastChannel` and `SharedWorker` to TryCatch EventTargets (#8943)
+- feat(core): Add `name` to `Span` (#8949)
+- feat(core): Add `ServerRuntimeClient` (#8930)
+- fix(node-experimental): Ensure `span.finish()` works as expected (#8947)
+- fix(remix): Add new sourcemap-upload script files to prepack assets. (#8948)
+- fix(publish): Publish downleveled TS3.8 types and fix types path (#8954)
+
+## 7.67.0
+
+### Important Changes
+
+- **feat: Mark errors caught by the SDK as unhandled**
+  - feat(browser): Mark errors caught from `TryCatch` integration as unhandled (#8890)
+  - feat(integrations): Mark errors caught from `HttpClient` and `CaptureConsole` integrations as unhandled (#8891)
+  - feat(nextjs): Mark errors caught from NextJS wrappers as unhandled (#8893)
+  - feat(react): Mark errors captured from ErrorBoundary as unhandled (#8914)
+  - feat(remix): Add debugid injection and map deletion to sourcemaps script (#8814)
+  - feat(remix): Mark errors caught from Remix instrumentation as unhandled (#8894)
+  - feat(serverless): Mark errors caught in Serverless handlers as unhandled (#8907)
+  - feat(vue): Mark errors caught by Vue wrappers as unhandled (#8905)
+
+This release fixes inconsistent behaviour of when our SDKs classify captured errors as unhandled.
+Previously, some of our instrumentations correctly set unhandled, while others set handled.
+Going forward, all errors caught automatically from our SDKs will be marked as unhandled.
+If you manually capture errors (e.g. by calling `Sentry.captureException`), your errors will continue to be reported as handled.
+
+This change might lead to a decrease in reported crash-free sessions and consequently in your release health score.
+If you have concerns about this, feel free to open an issue.
+
+### Other Changes
+
+- feat(node-experimental): Implement new performance APIs (#8911)
+- feat(node-experimental): Sync OTEL context with Sentry AsyncContext (#8797)
+- feat(replay): Allow to configure `maxReplayDuration` (#8769)
+- fix(browser): Add replay and profiling options to `BrowserClientOptions` (#8921)
+- fix(browser): Check for existence of instrumentation targets (#8939)
+- fix(nextjs): Don't re-export default in route handlers (#8924)
+- fix(node): Improve mysql integration (#8923)
+- fix(remix): Guard against missing default export for server instrument (#8909)
+- ref(browser): Deprecate top-level `wrap` function (#8927)
+- ref(node-otel): Avoid exporting internals & refactor attribute adding (#8920)
+
+Work in this release contributed by @SorsOps. Thank you for your contribution!
+
 ## 7.66.0
 
 - fix: Defer tracing decision to downstream SDKs when using SDK without performance (#8839)

MIGRATION.md

@@ -1,5 +1,13 @@
 # Deprecations in 7.x
 
+You can use the **Experimental** [@sentry/migr8](https://www.npmjs.com/package/@sentry/migr8) to automatically update your SDK usage and fix most deprecations. This requires Node 18+.
+
+```bash
+npx @sentry/migr8@latest
+```
+
+This will let you select which updates to run, and automatically update your code. Make sure to still review all code changes!
+
 ## Deprecate `timestampWithMs` export - #7878
 
 The `timestampWithMs` util is deprecated in favor of using `timestampInSeconds`.

lerna.json

@@ -1,5 +1,5 @@
 {
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
-  "version": "7.66.0",
+  "version": "7.68.0",
   "npmClient": "yarn"
 }

packages/angular-ivy/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/angular-ivy",
-  "version": "7.66.0",
+  "version": "7.68.0",
   "description": "Official Sentry SDK for Angular with full Ivy Support",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/angular-ivy",
@@ -21,9 +21,9 @@
     "rxjs": "^6.5.5 || ^7.x"
   },
   "dependencies": {
-    "@sentry/browser": "7.66.0",
-    "@sentry/types": "7.66.0",
-    "@sentry/utils": "7.66.0",
+    "@sentry/browser": "7.68.0",
+    "@sentry/types": "7.68.0",
+    "@sentry/utils": "7.68.0",
     "tslib": "^2.4.1"
   },
   "devDependencies": {

packages/angular/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/angular",
-  "version": "7.66.0",
+  "version": "7.68.0",
   "description": "Official Sentry SDK for Angular",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/angular",
@@ -21,9 +21,9 @@
     "rxjs": "^6.5.5 || ^7.x"
   },
   "dependencies": {
-    "@sentry/browser": "7.66.0",
-    "@sentry/types": "7.66.0",
-    "@sentry/utils": "7.66.0",
+    "@sentry/browser": "7.68.0",
+    "@sentry/types": "7.68.0",
+    "@sentry/utils": "7.68.0",
     "tslib": "^2.4.1"
   },
   "devDependencies": {

packages/angular/test/errorhandler.test.ts

@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
           }),
         };
 
-        // @ts-ignore this is a minmal hub, we're missing a few props but that's ok
+        // @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
         jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
           return { getClient: () => client };
         });

packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "7.66.0",
+  "version": "7.68.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {

packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts

@@ -38,7 +38,7 @@ sentryTest(
             value: 'HTTP Client Error with status code: 500',
             mechanism: {
               type: 'http.client',
-              handled: true,
+              handled: false,
             },
           },
         ],

packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts

@@ -38,7 +38,7 @@ sentryTest(
             value: 'HTTP Client Error with status code: 500',
             mechanism: {
               type: 'http.client',
-              handled: true,
+              handled: false,
             },
           },
         ],

packages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts

@@ -36,7 +36,7 @@ sentryTest('works with a Request passed in', async ({ getLocalTestPath, page })
           value: 'HTTP Client Error with status code: 500',
           mechanism: {
             type: 'http.client',
-            handled: true,
+            handled: false,
           },
         },
       ],

packages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts

@@ -38,7 +38,7 @@ sentryTest(
             value: 'HTTP Client Error with status code: 500',
             mechanism: {
               type: 'http.client',
-              handled: true,
+              handled: false,
             },
           },
         ],

packages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts

@@ -36,7 +36,7 @@ sentryTest('works with a Request (without body) & options passed in', async ({ g
           value: 'HTTP Client Error with status code: 500',
           mechanism: {
             type: 'http.client',
-            handled: true,
+            handled: false,
           },
         },
       ],

packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts

@@ -38,7 +38,7 @@ sentryTest(
             value: 'HTTP Client Error with status code: 500',
             mechanism: {
               type: 'http.client',
-              handled: true,
+              handled: false,
             },
           },
         ],

packages/browser-integration-tests/suites/public-api/instrumentation/eventListener/test.ts

@@ -17,7 +17,7 @@ sentryTest(
       value: 'event_listener_error',
       mechanism: {
         type: 'instrument',
-        handled: true,
+        handled: false,
       },
       stacktrace: {
         frames: expect.any(Array),

packages/browser-integration-tests/suites/replay/bufferMode/test.ts

@@ -68,7 +68,7 @@ sentryTest(
     expect(
       await page.evaluate(() => {
         const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
-        // @ts-ignore private
+        // @ts-expect-error private
         const replay = replayIntegration._replay;
         replayIntegration.startBuffering();
         return replay.isEnabled();
@@ -210,7 +210,7 @@ sentryTest(
     expect(
       await page.evaluate(() => {
         const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
-        // @ts-ignore private
+        // @ts-expect-error private
         const replay = replayIntegration._replay;
         replayIntegration.startBuffering();
         return replay.isEnabled();

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts

@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
       method: 'POST',
       body: 'input body',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
       method: 'POST',
       body: '{"foo":"bar"}',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
       method: 'POST',
       body: body,
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
       method: 'POST',
       body: 'input body',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
       method: 'POST',
       body: 'input body',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts

@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
     fetch('http://localhost:7654/foo', {
       method: 'POST',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
         'X-Test-Header': 'test-value',
       },
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
     });
     /* eslint-disable */
     fetch(request).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
       method: 'POST',
       headers,
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
         'X-Test-Header': 'test-value',
       },
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts

@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
       method: 'POST',
       body: '{"foo":"bar"}',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
       method: 'POST',
       body: blob,
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts

@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
     fetch('http://localhost:7654/foo', {
       method: 'POST',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
     fetch('http://localhost:7654/foo', {
       method: 'POST',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
     fetch('http://localhost:7654/foo', {
       method: 'POST',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */
@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
     fetch('http://localhost:7654/bar', {
       method: 'POST',
     }).then(() => {
-      // @ts-ignore Sentry is a global
+      // @ts-expect-error Sentry is a global
       Sentry.captureException('test error');
     });
     /* eslint-enable */