Skip to content

Commit bde8318

Browse files
authored
meta: Postpone non-breaking TODOs (#15080)
1 parent 6323549 commit bde8318

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

packages/aws-serverless/src/sdk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export function wrapHandler<TEvent, TResult>(
333333
// Only start a trace and root span if the handler is not already wrapped by Otel instrumentation
334334
// Otherwise, we create two root spans (one from otel, one from our wrapper).
335335
// If Otel instrumentation didn't work or was filtered by users, we still want to trace the handler.
336-
// TODO(v9): Since bumping the OTEL Instrumentation, this is likely not needed anymore, we can possibly remove this
336+
// TODO: Since bumping the OTEL Instrumentation, this is likely not needed anymore, we can possibly remove this (can be done whenever since it would be non-breaking)
337337
if (options.startTrace && !isWrappedByOtel(handler)) {
338338
const traceData = getAwsTraceData(event as { headers?: Record<string, string> }, context);
339339

packages/core/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ export type { ReportDialogOptions } from './report-dialog';
118118
// eslint-disable-next-line deprecation/deprecation
119119
export { getCurrentHubShim, getCurrentHub } from './getCurrentHubShim';
120120

121-
// TODO(v9): Make this structure pretty again and don't do "export *"
121+
// TODO: Make this structure pretty again and don't do "export *"
122122
export * from './utils-hoist/index';
123-
// TODO(v9): Make this structure pretty again and don't do "export *"
123+
// TODO: Make this structure pretty again and don't do "export *"
124124
export * from './types-hoist/index';
125125

126126
export type { FeatureFlag } from './featureFlags';

packages/nextjs/src/config/webpack.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ function setUpModuleRules(newConfig: WebpackConfigObject): WebpackConfigObjectWi
586586
/**
587587
* Adds loaders to inject values on the global object based on user configuration.
588588
*/
589-
// TODO(v9): Remove this loader and replace it with a nextConfig.env (https://web.archive.org/web/20240917153554/https://nextjs.org/docs/app/api-reference/next-config-js/env) or define based (https://github.com/vercel/next.js/discussions/71476) approach.
589+
// TODO: Remove this loader and replace it with a nextConfig.env (https://web.archive.org/web/20240917153554/https://nextjs.org/docs/app/api-reference/next-config-js/env) or define based (https://github.com/vercel/next.js/discussions/71476) approach.
590590
// In order to remove this loader though we need to make sure the minimum supported Next.js version includes this PR (https://github.com/vercel/next.js/pull/61194), otherwise the nextConfig.env based approach will not work, as our SDK code is not processed by Next.js.
591591
function addValueInjectionLoader(
592592
newConfig: WebpackConfigObjectWithModuleRules,

packages/nextjs/src/config/withSentryConfig.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,7 @@ function setUpTunnelRewriteRules(userNextConfig: NextConfigObject, tunnelPath: s
248248
};
249249
}
250250

251-
// TODO(v9): Inject the release into all the bundles. This is breaking because grabbing the build ID if the user provides
252-
// it in `generateBuildId` (https://nextjs.org/docs/app/api-reference/next-config-js/generateBuildId) is async but we do
253-
// not turn the next config function in the type it was passed.
251+
// TODO: For Turbopack we need to pass the release name here and pick it up in the SDK
254252
function setUpBuildTimeVariables(userNextConfig: NextConfigObject, userSentryOptions: SentryBuildOptions): void {
255253
const assetPrefix = userNextConfig.assetPrefix || userNextConfig.basePath || '';
256254
const basePath = userNextConfig.basePath ?? '';

0 commit comments

Comments
 (0)