- move tunnel check from @sentry/nextjs to @sentry/node

- Use `console.warn` instead of `logger.warn`
- Do not re-throw the error

Author: Naddiseo

packages/nextjs/src/index.server.ts

@@ -79,15 +79,6 @@ export function init(options: NextjsOptions): void {
   const activeDomain = domain.active;
   domain.active = null;
 
-  if (typeof options.tunnel !== 'undefined') {
-    try {
-      new URL(options.tunnel);
-    } catch (error) {
-      __DEBUG_BUILD__ &&
-        logger.error('The tunnel option is not a valid URL. It must be a full URL including the protocol.');
-      throw new Error('The tunnel option is not a valid URL. It must be a full URL including the protocol.');
-    }
-  }
   nodeInit(options);
 
   const filterTransactions: EventProcessor = event => {

packages/nextjs/test/index.server.test.ts

@@ -140,21 +140,29 @@ describe('Server init()', () => {
   });
 
   it('should not fail on valid tunnel option', () => {
+    const consoleWarnSpy = jest.spyOn(console, 'warn');
     expect(() =>
       init({
         dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012',
         tunnel: 'https://example.com/api',
       }),
     ).not.toThrowError();
+    expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+      'The tunnel option is not a valid URL. It must be a full URL including the protocol when using the Node transport.',
+    );
   });
 
-  it('should fail on invalid tunnel option', () => {
-    expect(() =>
-      init({
-        dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012',
-        tunnel: '/invalid',
-      }),
-    ).toThrowError('The tunnel option is not a valid URL. It must be a full URL including the protocol.');
+  it('should not fail on invalid tunnel option', () => {
+    const consoleWarnSpy = jest.spyOn(console, 'warn');
+
+    init({
+      dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012',
+      tunnel: '/invalid',
+    });
+
+    expect(consoleWarnSpy).toHaveBeenCalledWith(
+      'The tunnel option is not a valid URL. It must be a full URL including the protocol when using the Node transport.',
+    );
   });
 
   describe('integrations', () => {

packages/node/src/sdk.ts

@@ -157,6 +157,8 @@ export function init(options: NodeOptions = {}): void {
     setHubOnCarrier(carrier, getCurrentHub());
   }
 
+  checkNodeTunnelOption(options);
+
   // TODO(v7): Refactor this to reduce the logic above
   const clientOptions: NodeClientOptions = {
     ...options,
@@ -172,6 +174,20 @@ export function init(options: NodeOptions = {}): void {
   }
 }
 
+function checkNodeTunnelOption(options: NodeOptions = {}): void {
+  if (options.tunnel !== undefined) {
+    try {
+      new URL(options.tunnel);
+    } catch (error) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        'The tunnel option is not a valid URL. It must be a full URL including the protocol when using the Node transport.',
+      );
+      options.tunnel = undefined;
+    }
+  }
+}
+
 /**
  * This is the getter for lastEventId.
  *

packages/node/test/sdk.test.ts

@@ -20,6 +20,7 @@ const defaultIntegrationsBackup = sdk.defaultIntegrations;
 
 describe('init()', () => {
   beforeEach(() => {
+    jest.clearAllMocks();
     global.__SENTRY__ = {};
   });
 
@@ -89,4 +90,28 @@ describe('init()', () => {
     expect(mockDefaultIntegrations[1].setupOnce as jest.Mock).toHaveBeenCalledTimes(0);
     expect(newIntegration.setupOnce as jest.Mock).toHaveBeenCalledTimes(1);
   });
+
+  it('should not error on valid tunnel option', () => {
+    const consoleWarnSpy = jest.spyOn(console, 'warn');
+    expect(() =>
+      init({
+        dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012',
+        tunnel: 'https://example.com/api',
+      }),
+    ).not.toThrowError();
+    expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+      'The tunnel option is not a valid URL. It must be a full URL including the protocol when using the Node transport.',
+    );
+  });
+
+  it('should not error on invalid tunnel option', () => {
+    const consoleWarnSpy = jest.spyOn(console, 'warn');
+    init({
+      dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012',
+      tunnel: '/invalid',
+    });
+    expect(consoleWarnSpy).toHaveBeenCalledWith(
+      'The tunnel option is not a valid URL. It must be a full URL including the protocol when using the Node transport.',
+    );
+  });
 });