Skip to content

Commit 9f4204b

Browse files
mydeas1gr1d
andcommitted
Apply suggestions from code review
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
1 parent 9750100 commit 9f4204b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/migration/v8-to-v9.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ Let us know if this is causing issues in your setup by opening an issue on GitHu
108108
## 6. Type Changes
109109

110110
In v8, types have been exported from `@sentry/types`, while implementations have been exported from other classes.
111-
This lead to some duplication, where we had to keep an interface in `@sentry/types`, while the implementation mirroring that interface was kept e.g. in `@sentry/core`.
112-
Since in v9 the types have been merged into `@sentry/core`, we can get rid of some of this duplication. This means that certain things that used to be a separate interface, will not expect an actual instance of the class/concrete implementation. This should not affect most users, unless you relied on passing things with a similar shape to internal methods. The following types are affected:
111+
This led to some duplication, where we had to keep an interface in `@sentry/types`, while the implementation mirroring that interface was kept e.g. in `@sentry/core`.
112+
Since v9, the types have been merged into `@sentry/core`, which removed some of this duplication. This means that certain things that used to be a separate interface, will not expect an actual instance of the class/concrete implementation. This should not affect most users, unless you relied on passing things with a similar shape to internal methods. The following types are affected:
113113

114114
- `Scope` now always expects the `Scope` class
115115

0 commit comments

Comments
 (0)