Skip to content

Commit 963eab7

Browse files
author
Luca Forstner
authored
test(nextjs): Fix canary tests (#12875)
1 parent 9c613be commit 963eab7

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/client-app-routing-instrumentation.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ test('Creates a navigation transaction for app router routes', async ({ page })
3939

4040
const serverComponentTransactionPromise = waitForTransaction('nextjs-app-dir', async transactionEvent => {
4141
return (
42-
transactionEvent?.transaction === 'GET /server-component/parameter/foo/bar/baz' &&
42+
// It seems to differ between Next.js versions whether the route is parameterized or not
43+
(transactionEvent?.transaction === 'GET /server-component/parameter/foo/bar/baz' ||
44+
transactionEvent?.transaction === 'GET /server-component/parameter/[...parameters]') &&
45+
transactionEvent.contexts?.trace?.data?.['http.target'].startsWith('/server-component/parameter/foo/bar/baz') &&
4346
(await clientNavigationTransactionPromise).contexts?.trace?.trace_id ===
4447
transactionEvent.contexts?.trace?.trace_id
4548
);

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/server-components.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
33

44
test('Sends a transaction for a request to app router', async ({ page }) => {
55
const serverComponentTransactionPromise = waitForTransaction('nextjs-app-dir', transactionEvent => {
6-
return transactionEvent?.transaction === 'GET /server-component/parameter/[...parameters]';
6+
return (
7+
transactionEvent?.transaction === 'GET /server-component/parameter/[...parameters]' &&
8+
transactionEvent.contexts?.trace?.data?.['http.target'].startsWith('/server-component/parameter/1337/42')
9+
);
710
});
811

912
await page.goto('/server-component/parameter/1337/42');

0 commit comments

Comments
 (0)