Skip to content

Commit 953e13d

Browse files
committed
fix test apps without name
1 parent 4960c3d commit 953e13d

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

dev-packages/e2e-tests/lib/getTestMatrix.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ function addIncludesForTestApp(
6161
const packageJson = getPackageJson(testApp);
6262

6363
// this means something went wrong
64-
if (!packageJson.name) {
64+
if (!packageJson) {
6565
return;
6666
}
6767

@@ -84,31 +84,30 @@ function addIncludesForTestApp(
8484
}
8585

8686
function getSentryDependencies(appName: string): string[] {
87-
const packageJson = getPackageJson(appName);
87+
const packageJson = getPackageJson(appName) || {};
8888

8989
const dependencies = {
9090
...packageJson.devDependencies,
9191
...packageJson.dependencies,
9292
};
9393

94-
return Object.keys(dependencies).filter(key => key.startsWith('@sentry/'));
94+
return Object.keys(dependencies).filter(key => key.startsWith('@sentry'));
9595
}
9696

9797
function getPackageJson(appName: string): {
98-
name?: string;
9998
dependencies?: { [key: string]: string };
10099
devDependencies?: { [key: string]: string };
101100
sentryTest?: {
102101
optional?: boolean;
103102
variants?: Partial<MatrixInclude>[];
104103
optionalVariants?: Partial<MatrixInclude>[];
105104
};
106-
} {
105+
} | undefined {
107106
const fullPath = path.resolve(__dirname, '..', 'test-applications', appName, 'package.json');
108107

109108
// This can happen if you e.g. have a leftover directory in test-applications
110109
if (!fs.existsSync(fullPath)) {
111-
return {};
110+
return undefined;
112111
}
113112

114113
return JSON.parse(fs.readFileSync(fullPath, 'utf8'));

0 commit comments

Comments
 (0)