Skip to content

Commit 785f36d

Browse files
author
Luca Forstner
committed
Add comment about build assertion
1 parent 3aaeb06 commit 785f36d

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/assert-build.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,21 @@ const buildStderr = fs.readFileSync('.tmp_build_stderr', 'utf-8');
1111
// if (nextjsVersion !== 'latest' && nextjsVersion !== 'canary') {
1212
// assert.doesNotMatch(buildStderr, /Import trace for requested module/); // This is Next.js/Webpack speech for "something is off"
1313
// }
14-
// Note(lforst): I disabled this for the time being to figure out OTEL + Next.js - Next.js is currently complaining about a critical import in the @opentelemetry/instrumentation package.
14+
// Note(lforst): I disabled this for the time being to figure out OTEL + Next.js - Next.js is currently complaining about a critical import in the @opentelemetry/instrumentation package. E.g:
15+
// --- Start logs ---
16+
// ./node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
17+
// ./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
18+
// Critical dependency: the request of a dependency is an expression
19+
// Import trace for requested module:
20+
// ./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
21+
// ./node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
22+
// ./node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
23+
// ./node_modules/@opentelemetry/instrumentation/build/esm/index.js
24+
// ./node_modules/@sentry/node/cjs/index.js
25+
// ./node_modules/@sentry/nextjs/cjs/server/index.js
26+
// ./node_modules/@sentry/nextjs/cjs/index.server.js
27+
// ./app/page.tsx
28+
// --- End logs ---
1529

1630
// Assert that all static components stay static and all dynamic components stay dynamic
1731
assert.match(buildStdout, / \/client-component/);

0 commit comments

Comments
 (0)