Skip to content

Commit 62056c1

Browse files
committed
add failing test for replayId
1 parent d400d69 commit 62056c1

File tree

1 file changed

+8
-4
lines changed
  • packages/browser-integration-tests/suites/replay/bufferMode

1 file changed

+8
-4
lines changed

packages/browser-integration-tests/suites/replay/bufferMode/test.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,11 @@ sentryTest('[buffer-mode] can sample on each error event', async ({ getLocalTest
345345
await page.click('#error');
346346
await new Promise(resolve => setTimeout(resolve, 1000));
347347

348-
// 1 error, no replay
349-
await reqErrorPromise;
348+
// 1 unsampled error, no replay
349+
const reqError0 = await reqErrorPromise;
350+
const errorEvent0 = envelopeRequestParser(reqError0);
350351
expect(callsToSentry).toEqual(1);
352+
expect(errorEvent0.tags?.replayId).toBeUndefined();
351353

352354
await page.evaluate(async () => {
353355
const replayIntegration = (window as unknown as Window & { Replay: Replay }).Replay;
@@ -359,9 +361,11 @@ sentryTest('[buffer-mode] can sample on each error event', async ({ getLocalTest
359361

360362
const req0 = await reqPromise0;
361363

362-
// 2 errors, 1 flush
363-
await reqErrorPromise;
364+
// 1 unsampled error, 1 sampled error -> 1 flush
365+
const reqError1 = await reqErrorPromise;
366+
const errorEvent1 = envelopeRequestParser(reqError1);
364367
expect(callsToSentry).toEqual(3);
368+
expect(errorEvent1.tags?.replayId).toBeDefined();
365369

366370
const event0 = getReplayEvent(req0);
367371
const content0 = getReplayRecordingContent(req0);

0 commit comments

Comments
 (0)