Skip to content

Commit 594176a

Browse files
committed
fix node version check??
1 parent 597c23a commit 594176a

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,15 +1245,19 @@ jobs:
12451245
(needs.job_get_metadata.outputs.changed_profiling_node == 'true') ||
12461246
(needs.job_get_metadata.outputs.is_release == 'true')
12471247
runs-on: ${{ matrix.os }}
1248-
container: ${{ matrix.container }}
1248+
container:
1249+
image: ${{ matrix.container }}
1250+
env:
1251+
NODE_VERSION: ${{ matrix.node }}
1252+
12491253
timeout-minutes: 30
12501254
strategy:
12511255
fail-fast: false
12521256
matrix:
12531257
include:
12541258
# x64 glibc
12551259
- os: ubuntu-20.04
1256-
node: 18
1260+
node: 18.19.1
12571261
binary: linux-x64-glibc-108
12581262
- os: ubuntu-20.04
12591263
node: 20
@@ -1265,7 +1269,7 @@ jobs:
12651269
# x64 musl
12661270
- os: ubuntu-20.04
12671271
container: node:18-alpine3.17
1268-
node: 18
1272+
node: 18.19.1
12691273
binary: linux-x64-musl-108
12701274
- os: ubuntu-20.04
12711275
container: node:20-alpine3.17
@@ -1279,7 +1283,7 @@ jobs:
12791283
# arm64 glibc
12801284
- os: ubuntu-20.04
12811285
arch: arm64
1282-
node: 18
1286+
node: 18.19.1
12831287
binary: linux-arm64-glibc-108
12841288
- os: ubuntu-20.04
12851289
arch: arm64
@@ -1294,7 +1298,7 @@ jobs:
12941298
- os: ubuntu-20.04
12951299
arch: arm64
12961300
container: node:18-alpine3.17
1297-
node: 18
1301+
node: 18.19.1
12981302
binary: linux-arm64-musl-108
12991303
- os: ubuntu-20.04
13001304
arch: arm64
@@ -1309,7 +1313,7 @@ jobs:
13091313

13101314
# macos x64
13111315
- os: macos-13
1312-
node: 18
1316+
node: 18.19.1
13131317
arch: x64
13141318
binary: darwin-x64-108
13151319
- os: macos-13
@@ -1324,7 +1328,7 @@ jobs:
13241328
# macos arm64
13251329
- os: macos-13
13261330
arch: arm64
1327-
node: 18
1331+
node: 18.19.1
13281332
target_platform: darwin
13291333
binary: darwin-arm64-108
13301334
- os: macos-13
@@ -1340,7 +1344,7 @@ jobs:
13401344

13411345
# windows x64
13421346
- os: windows-2022
1343-
node: 18
1347+
node: 18.19.1
13441348
arch: x64
13451349
binary: win32-x64-108
13461350
- os: windows-2022
@@ -1366,17 +1370,9 @@ jobs:
13661370

13671371
- name: Setup Node
13681372
uses: actions/setup-node@v4
1369-
if: matrix.node != '18'
13701373
with:
13711374
node-version: ${{ matrix.node }}
13721375

1373-
# We need to make sure to use a proper version of v18 that satisifes our minimum version
1374-
- name: Setup Node (v18)
1375-
uses: actions/setup-node@v4
1376-
if: matrix.node != '18'
1377-
with:
1378-
node-version-file: 'package.json'
1379-
13801376
- name: Restore dependency cache
13811377
uses: actions/cache/restore@v4
13821378
id: restore-dependencies

0 commit comments

Comments
 (0)