tests n stuff

Author: Luca Forstner

packages/nextjs/src/config/types.ts

@@ -48,7 +48,7 @@ export type NextConfigObject = {
   >;
 };
 
-export type UserSentryOptions = {
+export type SentryBuildtimeOptions = {
   /**
    * Override the SDK's default decision about whether or not to enable to the Sentry webpack plugin for server files.
    * Note that `false` forces the plugin to be enabled, even in situations where it's not recommended.

packages/nextjs/src/config/webpack.ts

@@ -18,7 +18,7 @@ import type {
   EntryPropertyObject,
   NextConfigObject,
   SentryWebpackPluginOptions,
-  UserSentryOptions,
+  SentryBuildtimeOptions,
   WebpackConfigFunction,
   WebpackConfigObject,
   WebpackConfigObjectWithModuleRules,
@@ -61,7 +61,7 @@ let showedMissingGlobalErrorWarningMsg = false;
 export function constructWebpackConfigFunction(
   userNextConfig: NextConfigObject = {},
   userSentryWebpackPluginOptions: Partial<SentryWebpackPluginOptions> = {},
-  userSentryOptions: UserSentryOptions = {},
+  userSentryOptions: SentryBuildtimeOptions = {},
 ): WebpackConfigFunction {
   // Will be called by nextjs and passed its default webpack configuration and context data about the build (whether
   // we're building server or client, whether we're in dev, what version of webpack we're using, etc). Note that
@@ -511,7 +511,7 @@ function findTranspilationRules(rules: WebpackModuleRule[] | undefined, projectD
 async function addSentryToEntryProperty(
   currentEntryProperty: WebpackEntryProperty,
   buildContext: BuildContext,
-  userSentryOptions: UserSentryOptions,
+  userSentryOptions: SentryBuildtimeOptions,
 ): Promise<EntryPropertyObject> {
   // The `entry` entry in a webpack config can be a string, array of strings, object, or function. By default, nextjs
   // sets it to an async function which returns the promise of an object of string arrays. Because we don't know whether
@@ -725,7 +725,7 @@ function shouldAddSentryToEntryPoint(entryPointName: string, runtime: 'node' | '
 export function getWebpackPluginOptions(
   buildContext: BuildContext,
   userPluginOptions: Partial<SentryWebpackPluginOptions>,
-  userSentryOptions: UserSentryOptions,
+  userSentryOptions: SentryBuildtimeOptions,
 ): SentryWebpackPluginOptions {
   const { buildId, isServer, config, dir: projectDir } = buildContext;
   const userNextConfig = config as NextConfigObject;
@@ -884,7 +884,7 @@ export function getWebpackPluginOptions(
 }
 
 /** Check various conditions to decide if we should run the plugin */
-function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions: UserSentryOptions): boolean {
+function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions: SentryBuildtimeOptions): boolean {
   const { isServer } = buildContext;
   const { disableServerWebpackPlugin, disableClientWebpackPlugin } = userSentryOptions;
 
@@ -900,7 +900,7 @@ function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions
 /** Handle warning messages about `hideSourceMaps` option. Can be removed in v9 or v10 (or whenever we consider that
  * enough people will have upgraded the SDK that the warning about the default in v8 - currently commented out - is
  * overkill). */
-function handleSourcemapHidingOptionWarning(userSentryOptions: UserSentryOptions, isServer: boolean): void {
+function handleSourcemapHidingOptionWarning(userSentryOptions: SentryBuildtimeOptions, isServer: boolean): void {
   // This is nextjs's own logging formatting, vendored since it's not exported. See
   // https://github.com/vercel/next.js/blob/c3ceeb03abb1b262032bd96457e224497d3bbcef/packages/next/build/output/log.ts#L3-L11
   // and
@@ -969,7 +969,7 @@ function setUpModuleRules(newConfig: WebpackConfigObject): WebpackConfigObjectWi
 function addValueInjectionLoader(
   newConfig: WebpackConfigObjectWithModuleRules,
   userNextConfig: NextConfigObject,
-  userSentryOptions: UserSentryOptions,
+  userSentryOptions: SentryBuildtimeOptions,
   buildContext: BuildContext,
   sentryWebpackPluginOptions: Partial<SentryWebpackPluginOptions>,
 ): void {

packages/nextjs/src/config/withSentryConfig.ts

@@ -5,47 +5,47 @@ import type {
   NextConfigFunction,
   NextConfigObject,
   SentryWebpackPluginOptions,
-  UserSentryOptions,
+  SentryBuildtimeOptions,
 } from './types';
 import { constructWebpackConfigFunction } from './webpack';
 
 let showedExportModeTunnelWarning = false;
 
 /**
- * Modifies the passed in Next.js configuration
+ * Modifies the passed in Next.js configuration with automatic build-time instrumentation and source map upload.
  *
- * @param nextConfig The existing config to be exported prior to adding Sentry
- * @param sentryWebpackPluginOptions Configuration for SentryWebpackPlugin
- * @param sentrySDKOptions Optional additional options to add as alternative to `sentry` property of config
+ * @param nextConfig A Next.js configuration object, as usually exported in `next.config.js` or `next.config.mjs`.
+ * @param sentryWebpackPluginOptions Options to configure the automatically included Sentry Webpack Plugin for source maps and release management in Sentry.
+ * @param sentryBuildtimeOptions Additional options to configure instrumentation and
  * @returns The modified config to be exported
  */
 export function withSentryConfig(
   nextConfig: NextConfig = {},
   sentryWebpackPluginOptions: Partial<SentryWebpackPluginOptions> = {},
-  sentrySDKOptions: UserSentryOptions = {},
+  sentryBuildtimeOptions: SentryBuildtimeOptions = {},
 ): NextConfigFunction | NextConfigObject {
   if (typeof nextConfig === 'function') {
     return function (this: unknown, ...webpackConfigFunctionArgs: unknown[]): ReturnType<NextConfigFunction> {
       const maybePromiseNextConfig: ReturnType<typeof nextConfig> = nextConfig.apply(this, webpackConfigFunctionArgs);
 
       if (isThenable(maybePromiseNextConfig)) {
         return maybePromiseNextConfig.then(promiseResultNextConfig => {
-          return getFinalConfigObject(promiseResultNextConfig, sentrySDKOptions, sentryWebpackPluginOptions);
+          return getFinalConfigObject(promiseResultNextConfig, sentryBuildtimeOptions, sentryWebpackPluginOptions);
         });
       }
 
-      return getFinalConfigObject(maybePromiseNextConfig, sentrySDKOptions, sentryWebpackPluginOptions);
+      return getFinalConfigObject(maybePromiseNextConfig, sentryBuildtimeOptions, sentryWebpackPluginOptions);
     };
   } else {
-    return getFinalConfigObject(nextConfig, sentrySDKOptions, sentryWebpackPluginOptions);
+    return getFinalConfigObject(nextConfig, sentryBuildtimeOptions, sentryWebpackPluginOptions);
   }
 }
 
 // Modify the materialized object form of the user's next config by deleting the `sentry` property and wrapping the
 // `webpack` property
 function getFinalConfigObject(
   incomingUserNextConfigObject: NextConfigObject,
-  userSentryOptions: UserSentryOptions,
+  userSentryOptions: SentryBuildtimeOptions,
   userSentryWebpackPluginOptions: Partial<SentryWebpackPluginOptions>,
 ): NextConfigObject {
   if ('sentry' in incomingUserNextConfigObject) {

packages/nextjs/test/config/fixtures.ts

@@ -3,7 +3,6 @@ import type {
   EntryPropertyFunction,
   ExportedNextConfig,
   NextConfigObject,
-  NextConfigObjectWithSentry,
   WebpackConfigObject,
 } from '../../src/config/types';
 
@@ -26,7 +25,7 @@ export const userNextConfig: NextConfigObject = {
 };
 
 /** Mocks of the arguments passed to `withSentryConfig` */
-export const exportedNextConfig = userNextConfig as NextConfigObjectWithSentry;
+export const exportedNextConfig = userNextConfig;
 export const userSentryWebpackPluginConfig = { org: 'squirrelChasers', project: 'simulator' };
 process.env.SENTRY_AUTH_TOKEN = 'dogsarebadatkeepingsecrets';
 process.env.SENTRY_RELEASE = 'doGsaREgReaT';

packages/nextjs/test/config/testUtils.ts

@@ -6,6 +6,7 @@ import type {
   EntryPropertyFunction,
   ExportedNextConfig,
   NextConfigObject,
+  SentryBuildtimeOptions,
   SentryWebpackPluginOptions,
   WebpackConfigObject,
   WebpackConfigObjectWithModuleRules,
@@ -28,8 +29,9 @@ export function materializeFinalNextConfig(
   exportedNextConfig: ExportedNextConfig,
   userSentryWebpackPluginConfig?: Partial<SentryWebpackPluginOptions>,
   runtimePhase?: string,
+  sentryBuildTimeOptions?: SentryBuildtimeOptions,
 ): NextConfigObject {
-  const sentrifiedConfig = withSentryConfig(exportedNextConfig, userSentryWebpackPluginConfig);
+  const sentrifiedConfig = withSentryConfig(exportedNextConfig, userSentryWebpackPluginConfig, sentryBuildTimeOptions);
   let finalConfigValues = sentrifiedConfig;
 
   if (typeof sentrifiedConfig === 'function') {
@@ -59,6 +61,7 @@ export async function materializeFinalWebpackConfig(options: {
   userSentryWebpackPluginConfig?: Partial<SentryWebpackPluginOptions>;
   incomingWebpackConfig: WebpackConfigObject;
   incomingWebpackBuildContext: BuildContext;
+  sentryBuildTimeOptions?: SentryBuildtimeOptions;
 }): Promise<WebpackConfigObjectWithModuleRules> {
   const { exportedNextConfig, userSentryWebpackPluginConfig, incomingWebpackConfig, incomingWebpackBuildContext } =
     options;
@@ -69,15 +72,11 @@ export async function materializeFinalWebpackConfig(options: {
       ? await exportedNextConfig('phase-production-build', defaultsObject)
       : exportedNextConfig;
 
-  // extract the `sentry` property as we do in `withSentryConfig`
-  const { sentry: sentryConfig } = materializedUserNextConfig;
-  delete materializedUserNextConfig.sentry;
-
   // get the webpack config function we'd normally pass back to next
   const webpackConfigFunction = constructWebpackConfigFunction(
     materializedUserNextConfig,
     userSentryWebpackPluginConfig,
-    sentryConfig,
+    options.sentryBuildTimeOptions ?? {},
   );
 
   // call it to get concrete values for comparison

packages/nextjs/test/config/webpack/constructWebpackConfig.test.ts

@@ -48,36 +48,38 @@ describe('constructWebpackConfigFunction()', () => {
   });
 
   it("doesn't set devtool if webpack plugin is disabled", () => {
-    const finalNextConfig = materializeFinalNextConfig({
-      ...exportedNextConfig,
-      webpack: () =>
-        ({
-          ...serverWebpackConfig,
-          devtool: 'something-besides-source-map',
-        }) as any,
-      sentry: { disableServerWebpackPlugin: true },
-    });
+    const finalNextConfig = materializeFinalNextConfig(
+      {
+        ...exportedNextConfig,
+        webpack: () =>
+          ({
+            ...serverWebpackConfig,
+            devtool: 'something-besides-source-map',
+          }) as any,
+      },
+      undefined,
+      undefined,
+      { disableServerWebpackPlugin: true },
+    );
+
     const finalWebpackConfig = finalNextConfig.webpack?.(serverWebpackConfig, serverBuildContext);
 
     expect(finalWebpackConfig?.devtool).not.toEqual('source-map');
   });
 
   it('allows for the use of `hidden-source-map` as `devtool` value for client-side builds', async () => {
-    const exportedNextConfigHiddenSourceMaps = {
-      ...exportedNextConfig,
-      sentry: { ...exportedNextConfig.sentry, hideSourceMaps: true },
-    };
-
     const finalClientWebpackConfig = await materializeFinalWebpackConfig({
-      exportedNextConfig: exportedNextConfigHiddenSourceMaps,
+      exportedNextConfig: exportedNextConfig,
       incomingWebpackConfig: clientWebpackConfig,
       incomingWebpackBuildContext: clientBuildContext,
+      sentryBuildTimeOptions: { hideSourceMaps: true },
     });
 
     const finalServerWebpackConfig = await materializeFinalWebpackConfig({
-      exportedNextConfig: exportedNextConfigHiddenSourceMaps,
+      exportedNextConfig: exportedNextConfig,
       incomingWebpackConfig: serverWebpackConfig,
       incomingWebpackBuildContext: serverBuildContext,
+      sentryBuildTimeOptions: { hideSourceMaps: true },
     });
 
     expect(finalClientWebpackConfig.devtool).toEqual('hidden-source-map');

packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts

@@ -3,7 +3,7 @@ import * as os from 'os';
 import * as path from 'path';
 import { default as SentryWebpackPlugin } from '@sentry/webpack-plugin';
 
-import type { BuildContext, ExportedNextConfig } from '../../../src/config/types';
+import type { BuildContext, ExportedNextConfig, SentryBuildtimeOptions } from '../../../src/config/types';
 import { getUserConfigFile, getWebpackPluginOptions } from '../../../src/config/webpack';
 import {
   clientBuildContext,
@@ -83,13 +83,14 @@ describe('Sentry webpack plugin config', () => {
     });
 
     it('has the correct value when building client bundles using `widenClientFileUpload` option', async () => {
-      const exportedNextConfigWithWidening = { ...exportedNextConfig, sentry: { widenClientFileUpload: true } };
+      const exportedNextConfigWithWidening = { ...exportedNextConfig };
       const buildContext = getBuildContext('client', exportedNextConfigWithWidening);
 
       const finalWebpackConfig = await materializeFinalWebpackConfig({
         exportedNextConfig: exportedNextConfigWithWidening,
         incomingWebpackConfig: clientWebpackConfig,
         incomingWebpackBuildContext: buildContext,
+        sentryBuildTimeOptions: { widenClientFileUpload: true },
       });
 
       const sentryWebpackPluginInstance = findWebpackPlugin(
@@ -180,11 +181,12 @@ describe('Sentry webpack plugin config', () => {
     });
 
     it('has the correct value when building client bundles using `widenClientFileUpload` option', async () => {
-      const exportedNextConfigWithWidening = { ...exportedNextConfig, sentry: { widenClientFileUpload: true } };
+      const exportedNextConfigWithWidening = { ...exportedNextConfig };
       const finalWebpackConfig = await materializeFinalWebpackConfig({
         exportedNextConfig: exportedNextConfigWithWidening,
         incomingWebpackConfig: clientWebpackConfig,
         incomingWebpackBuildContext: getBuildContext('client', exportedNextConfigWithWidening),
+        sentryBuildTimeOptions: { widenClientFileUpload: true },
       });
 
       const sentryWebpackPluginInstance = findWebpackPlugin(
@@ -219,8 +221,8 @@ describe('Sentry webpack plugin config', () => {
         'obeys `disableClientWebpackPlugin = true`',
         {
           ...exportedNextConfig,
-          sentry: { disableClientWebpackPlugin: true },
         },
+        { disableClientWebpackPlugin: true },
         {},
         true,
         false,
@@ -230,8 +232,8 @@ describe('Sentry webpack plugin config', () => {
         'obeys `disableServerWebpackPlugin = true`',
         {
           ...exportedNextConfig,
-          sentry: { disableServerWebpackPlugin: true },
         },
+        { disableServerWebpackPlugin: true },
         {},
         false,
         true,
@@ -241,6 +243,7 @@ describe('Sentry webpack plugin config', () => {
       async (
         _testName: string,
         exportedNextConfig: ExportedNextConfig,
+        buildTimeOptions: SentryBuildtimeOptions,
         extraEnvValues: Record<string, string>,
         shouldFindServerPlugin: boolean,
         shouldFindClientPlugin: boolean,
@@ -254,13 +257,15 @@ describe('Sentry webpack plugin config', () => {
           userSentryWebpackPluginConfig,
           incomingWebpackConfig: serverWebpackConfig,
           incomingWebpackBuildContext: serverBuildContext,
+          sentryBuildTimeOptions: buildTimeOptions,
         });
 
         const clientFinalWebpackConfig = await materializeFinalWebpackConfig({
           exportedNextConfig: { ...exportedNextConfig },
           userSentryWebpackPluginConfig,
           incomingWebpackConfig: clientWebpackConfig,
           incomingWebpackBuildContext: clientBuildContext,
+          sentryBuildTimeOptions: buildTimeOptions,
         });
 
         const genericSentryWebpackPluginInstance = expect.any(SentryWebpackPlugin);

packages/nextjs/test/config/withSentryConfig.test.ts

@@ -49,14 +49,4 @@ describe('withSentryConfig', () => {
 
     expect(exportedNextConfigFunction).toHaveBeenCalledWith(defaultRuntimePhase, defaultsObject);
   });
-
-  it('removes `sentry` property', () => {
-    // It's unclear why we need this cast -
-    const finalConfig = materializeFinalNextConfig({ ...exportedNextConfig, sentry: {} });
-    // const finalConfig = materializeFinalNextConfig({ ...exportedNextConfig, sentry: {} } as ExportedNextConfig);
-
-    // We have to check using `in` because TS knows it shouldn't be there and throws a type error if we try to access it
-    // directly
-    expect('sentry' in finalConfig).toBe(false);
-  });
 });