Skip to content

Commit 5069029

Browse files
committed
cleanup and e2e test
1 parent a0bc030 commit 5069029

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

dev-packages/e2e-tests/test-applications/sveltekit-2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@sentry/core": "latest || *",
2424
"@sveltejs/adapter-auto": "^3.0.0",
2525
"@sveltejs/adapter-node": "^2.0.0",
26-
"@sveltejs/kit": "^2.5.0",
26+
"@sveltejs/kit": "^2.16.0",
2727
"@sveltejs/vite-plugin-svelte": "^3.0.0",
2828
"svelte": "^4.2.8",
2929
"svelte-check": "^3.6.0",
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import { expect, test } from '@playwright/test';
2+
import { waitForInitialPageload } from './utils';
3+
4+
test.describe('SDK-internal behavior', () => {
5+
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
6+
await waitForInitialPageload(page, { route: '/client-error' });
7+
const proxyHandle = await page.waitForFunction(() => globalThis._sentryFetchProxy);
8+
expect(proxyHandle).toBeUndefined();
9+
});
10+
});

packages/sveltekit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"author": "Sentry",
88
"license": "MIT",
99
"engines": {
10-
"node": ">=16"
10+
"node": ">=18"
1111
},
1212
"files": ["/build"],
1313
"main": "build/cjs/index.server.js",

packages/sveltekit/src/server/handle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
winterCGRequestToRequestData,
1515
withIsolationScope,
1616
} from '@sentry/core';
17-
import { type Handle, type ResolveOptions } from '@sveltejs/kit';
17+
import type { Handle, ResolveOptions } from '@sveltejs/kit';
1818

1919
import { DEBUG_BUILD } from '../common/debug-build';
2020
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

packages/sveltekit/src/vite/sentryVitePlugins.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ export async function sentrySvelteKit(options: SentrySvelteKitPluginOptions = {}
2626
adapter: options.adapter || (await detectAdapter(options.debug)),
2727
};
2828

29-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
30-
// @ts-ignore - just testing for now
31-
const kit = await import('@sveltejs/kit');
32-
console.log('XX kit version', kit.VERSION);
33-
3429
const sentryPlugins: Plugin[] = [];
3530

3631
if (mergedOptions.autoInstrument) {

0 commit comments

Comments
 (0)