Skip to content

Commit 49b9ec3

Browse files
authored
fix(tracing): Update prisma span to be db.prisma (#9512)
Prisma can be used for NoSQL dbs like mongo, so change the span op from `db.sql.prisma` to `db.prisma`
1 parent f013f1e commit 49b9ec3

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

packages/node-integration-tests/suites/tracing-new/prisma-orm/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
1010
spans: [
1111
{
1212
description: 'User create',
13-
op: 'db.sql.prisma',
13+
op: 'db.prisma',
1414
data: { 'db.system': 'postgresql', 'db.operation': 'create', 'db.prisma.version': '3.12.0' },
1515
},
1616
{
1717
description: 'User findMany',
18-
op: 'db.sql.prisma',
18+
op: 'db.prisma',
1919
data: { 'db.system': 'postgresql', 'db.operation': 'findMany', 'db.prisma.version': '3.12.0' },
2020
},
2121
{
2222
description: 'User deleteMany',
23-
op: 'db.sql.prisma',
23+
op: 'db.prisma',
2424
data: { 'db.system': 'postgresql', 'db.operation': 'deleteMany', 'db.prisma.version': '3.12.0' },
2525
},
2626
],

packages/node-integration-tests/suites/tracing/prisma-orm/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
1010
spans: [
1111
{
1212
description: 'User create',
13-
op: 'db.sql.prisma',
13+
op: 'db.prisma',
1414
data: { 'db.system': 'postgresql', 'db.operation': 'create', 'db.prisma.version': '3.12.0' },
1515
},
1616
{
1717
description: 'User findMany',
18-
op: 'db.sql.prisma',
18+
op: 'db.prisma',
1919
data: { 'db.system': 'postgresql', 'db.operation': 'findMany', 'db.prisma.version': '3.12.0' },
2020
},
2121
{
2222
description: 'User deleteMany',
23-
op: 'db.sql.prisma',
23+
op: 'db.prisma',
2424
data: { 'db.system': 'postgresql', 'db.operation': 'deleteMany', 'db.prisma.version': '3.12.0' },
2525
},
2626
],

packages/tracing-internal/src/node/integrations/prisma.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export class Prisma implements Integration {
101101
return trace(
102102
{
103103
name: model ? `${model} ${action}` : action,
104-
op: 'db.sql.prisma',
104+
op: 'db.prisma',
105105
origin: 'auto.db.prisma',
106106
data: { ...clientData, 'db.operation': action },
107107
},

packages/tracing/test/integrations/node/prisma.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe('setupOnce', function () {
5555
expect(mockTrace).toHaveBeenLastCalledWith(
5656
{
5757
name: 'user create',
58-
op: 'db.sql.prisma',
58+
op: 'db.prisma',
5959
origin: 'auto.db.prisma',
6060
data: { 'db.system': 'postgresql', 'db.prisma.version': '3.1.2', 'db.operation': 'create' },
6161
},

0 commit comments

Comments
 (0)