Skip to content

Commit 4794bbf

Browse files
mydeamydea
committed
ref: Refactor internal usages of startTransaction hook
1 parent b08a3c8 commit 4794bbf

File tree

5 files changed

+67
-51
lines changed

5 files changed

+67
-51
lines changed

‎packages/bun/test/integrations/bunserver.test.ts

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ describe('Bun Serve Integration', () => {
2323
});
2424

2525
test('generates a transaction around a request', async () => {
26-
client.on('finishTransaction', transaction => {
27-
expect(spanToJSON(transaction).status).toBe('ok');
28-
expect(spanToJSON(transaction).data?.['http.response.status_code']).toEqual(200);
29-
expect(spanToJSON(transaction).op).toEqual('http.server');
30-
expect(spanToJSON(transaction).description).toEqual('GET /');
26+
client.on('spanEnd', span => {
27+
expect(spanToJSON(span).status).toBe('ok');
28+
expect(spanToJSON(span).data?.['http.response.status_code']).toEqual(200);
29+
expect(spanToJSON(span).op).toEqual('http.server');
30+
expect(spanToJSON(span).description).toEqual('GET /');
3131
});
3232

3333
const server = Bun.serve({
@@ -43,11 +43,11 @@ describe('Bun Serve Integration', () => {
4343
});
4444

4545
test('generates a post transaction', async () => {
46-
client.on('finishTransaction', transaction => {
47-
expect(spanToJSON(transaction).status).toBe('ok');
48-
expect(spanToJSON(transaction).data?.['http.response.status_code']).toEqual(200);
49-
expect(spanToJSON(transaction).op).toEqual('http.server');
50-
expect(spanToJSON(transaction).description).toEqual('POST /');
46+
client.on('spanEnd', span => {
47+
expect(spanToJSON(span).status).toBe('ok');
48+
expect(spanToJSON(span).data?.['http.response.status_code']).toEqual(200);
49+
expect(spanToJSON(span).op).toEqual('http.server');
50+
expect(spanToJSON(span).description).toEqual('POST /');
5151
});
5252

5353
const server = Bun.serve({
@@ -72,14 +72,13 @@ describe('Bun Serve Integration', () => {
7272
const SENTRY_TRACE_HEADER = `${TRACE_ID}-${PARENT_SPAN_ID}-${PARENT_SAMPLED}`;
7373
const SENTRY_BAGGAGE_HEADER = 'sentry-version=1.0,sentry-environment=production';
7474

75-
client.on('finishTransaction', transaction => {
76-
expect(transaction.spanContext().traceId).toBe(TRACE_ID);
77-
expect(transaction.parentSpanId).toBe(PARENT_SPAN_ID);
78-
expect(spanIsSampled(transaction)).toBe(true);
79-
// span.endTimestamp is already set in `finishTransaction` hook
80-
expect(transaction.isRecording()).toBe(false);
75+
client.on('spanEnd', span => {
76+
expect(span.spanContext().traceId).toBe(TRACE_ID);
77+
expect(spanToJSON(span).parent_span_id).toBe(PARENT_SPAN_ID);
78+
expect(spanIsSampled(span)).toBe(true);
79+
expect(span.isRecording()).toBe(false);
8180

82-
expect(getDynamicSamplingContextFromSpan(transaction)).toStrictEqual({
81+
expect(getDynamicSamplingContextFromSpan(span)).toStrictEqual({
8382
version: '1.0',
8483
environment: 'production',
8584
});
@@ -100,7 +99,7 @@ describe('Bun Serve Integration', () => {
10099
});
101100

102101
test('does not create transactions for OPTIONS or HEAD requests', async () => {
103-
client.on('finishTransaction', () => {
102+
client.on('spanEnd', () => {
104103
// This will never run, but we want to make sure it doesn't run.
105104
expect(false).toEqual(true);
106105
});

‎packages/core/test/lib/tracing/trace.test.ts

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
startSpanManual,
2121
} from '../../../src/tracing';
2222
import { SentryNonRecordingSpan } from '../../../src/tracing/sentryNonRecordingSpan';
23-
import { getSpanDescendants } from '../../../src/utils/spanUtils';
23+
import { getRootSpan, getSpanDescendants } from '../../../src/utils/spanUtils';
2424
import { TestClient, getDefaultTestClientOptions } from '../../mocks/client';
2525

2626
beforeAll(() => {
@@ -96,8 +96,8 @@ describe('startSpan', () => {
9696

9797
it('creates a transaction', async () => {
9898
let _span: Span | undefined = undefined;
99-
client.on('finishTransaction', transaction => {
100-
_span = transaction;
99+
client.on('spanEnd', span => {
100+
_span = span;
101101
});
102102
try {
103103
await startSpan({ name: 'GET users/[id]' }, () => {
@@ -114,8 +114,8 @@ describe('startSpan', () => {
114114

115115
it('allows traceparent information to be overriden', async () => {
116116
let _span: Span | undefined = undefined;
117-
client.on('finishTransaction', transaction => {
118-
_span = transaction;
117+
client.on('spanEnd', span => {
118+
_span = span;
119119
});
120120
try {
121121
await startSpan(
@@ -141,8 +141,8 @@ describe('startSpan', () => {
141141

142142
it('allows for transaction to be mutated', async () => {
143143
let _span: Span | undefined = undefined;
144-
client.on('finishTransaction', transaction => {
145-
_span = transaction;
144+
client.on('spanEnd', span => {
145+
_span = span;
146146
});
147147
try {
148148
await startSpan({ name: 'GET users/[id]' }, span => {
@@ -158,8 +158,10 @@ describe('startSpan', () => {
158158

159159
it('creates a span with correct description', async () => {
160160
let _span: Span | undefined = undefined;
161-
client.on('finishTransaction', transaction => {
162-
_span = transaction;
161+
client.on('spanEnd', span => {
162+
if (span === getRootSpan(span)) {
163+
_span = span;
164+
}
163165
});
164166
try {
165167
await startSpan({ name: 'GET users/[id]', parentSampled: true }, () => {
@@ -182,8 +184,10 @@ describe('startSpan', () => {
182184

183185
it('allows for span to be mutated', async () => {
184186
let _span: Span | undefined = undefined;
185-
client.on('finishTransaction', transaction => {
186-
_span = transaction;
187+
client.on('spanEnd', span => {
188+
if (span === getRootSpan(span)) {
189+
_span = span;
190+
}
187191
});
188192
try {
189193
await startSpan({ name: 'GET users/[id]', parentSampled: true }, () => {
@@ -212,8 +216,8 @@ describe('startSpan', () => {
212216
{ origin: 'manual', attributes: { 'sentry.origin': 'auto.http.browser' } },
213217
])('correctly sets the span origin', async () => {
214218
let _span: Span | undefined = undefined;
215-
client.on('finishTransaction', transaction => {
216-
_span = transaction;
219+
client.on('spanEnd', span => {
220+
_span = span;
217221
});
218222
try {
219223
await startSpan({ name: 'GET users/[id]', origin: 'auto.http.browser' }, () => {

‎packages/replay/src/types/replay.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type {
66
ReplayRecordingData,
77
ReplayRecordingMode,
88
SentryWrappedXMLHttpRequest,
9-
Transaction,
9+
Span,
1010
XhrBreadcrumbHint,
1111
} from '@sentry/types';
1212

@@ -478,7 +478,7 @@ export interface ReplayContainer {
478478
session: Session | undefined;
479479
recordingMode: ReplayRecordingMode;
480480
timeouts: Timeouts;
481-
lastTransaction?: Transaction;
481+
lastActiveSpan?: Span;
482482
throttledAddEvent: (
483483
event: RecordingEvent,
484484
isCheckout?: boolean,

‎packages/replay/src/util/addGlobalListeners.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ export function addGlobalListeners(replay: ReplayContainer): void {
4444
}
4545
});
4646

47-
client.on('startTransaction', transaction => {
48-
replay.lastTransaction = transaction;
47+
client.on('spanStart', span => {
48+
replay.lastActiveSpan = span;
4949
});
5050

51-
// We may be missing the initial startTransaction due to timing issues,
51+
// We may be missing the initial spanStart due to timing issues,
5252
// so we capture it on finish again.
53-
client.on('finishTransaction', transaction => {
54-
replay.lastTransaction = transaction;
53+
client.on('spanEnd', span => {
54+
replay.lastActiveSpan = span;
5555
});
5656

5757
// We want to flush replay

‎packages/sveltekit/test/server/handle.test.ts

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {
22
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
33
addTracingExtensions,
4+
getRootSpan,
45
getSpanDescendants,
56
spanIsSampled,
67
spanToJSON,
@@ -124,8 +125,10 @@ describe('handleSentry', () => {
124125

125126
it("creates a transaction if there's no active span", async () => {
126127
let _span: Span | undefined = undefined;
127-
client.on('finishTransaction', (transaction: Transaction) => {
128-
_span = transaction;
128+
client.on('spanEnd', span => {
129+
if (span === getRootSpan(span)) {
130+
_span = span;
131+
}
129132
});
130133

131134
try {
@@ -150,9 +153,11 @@ describe('handleSentry', () => {
150153
it('creates a child span for nested server calls (i.e. if there is an active span)', async () => {
151154
let _span: Span | undefined = undefined;
152155
let txnCount = 0;
153-
client.on('finishTransaction', (transaction: Transaction) => {
154-
_span = transaction;
155-
++txnCount;
156+
client.on('spanEnd', span => {
157+
if (span === getRootSpan(span)) {
158+
_span = span;
159+
++txnCount;
160+
}
156161
});
157162

158163
try {
@@ -208,8 +213,10 @@ describe('handleSentry', () => {
208213
});
209214

210215
let _span: Span | undefined = undefined;
211-
client.on('finishTransaction', (transaction: Transaction) => {
212-
_span = transaction;
216+
client.on('spanEnd', span => {
217+
if (span === getRootSpan(span)) {
218+
_span = span;
219+
}
213220
});
214221

215222
try {
@@ -248,8 +255,10 @@ describe('handleSentry', () => {
248255
});
249256

250257
let _span: Span | undefined = undefined;
251-
client.on('finishTransaction', (transaction: Transaction) => {
252-
_span = transaction;
258+
client.on('spanEnd', span => {
259+
if (span === getRootSpan(span)) {
260+
_span = span;
261+
}
253262
});
254263

255264
try {
@@ -312,8 +321,10 @@ describe('handleSentry', () => {
312321

313322
it("doesn't create a transaction if there's no route", async () => {
314323
let _span: Span | undefined = undefined;
315-
client.on('finishTransaction', (transaction: Transaction) => {
316-
_span = transaction;
324+
client.on('spanEnd', span => {
325+
if (span === getRootSpan(span)) {
326+
_span = span;
327+
}
317328
});
318329

319330
try {
@@ -327,8 +338,10 @@ describe('handleSentry', () => {
327338

328339
it("Creates a transaction if there's no route but `handleUnknownRequests` is true", async () => {
329340
let _span: Span | undefined = undefined;
330-
client.on('finishTransaction', (transaction: Transaction) => {
331-
_span = transaction;
341+
client.on('spanEnd', span => {
342+
if (span === getRootSpan(span)) {
343+
_span = span;
344+
}
332345
});
333346

334347
try {

0 commit comments

Comments
 (0)