chore: Make _wasSkipped field on integrations private

Author: mydea

packages/node/src/integrations/http.ts

@@ -41,7 +41,8 @@ export class Http implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * @inheritDoc

packages/node/test/integrations/http.test.ts

@@ -1,7 +1,7 @@
 import * as sentryCore from '@sentry/core';
 import { Hub } from '@sentry/core';
 import { addExtensionMethods, Span, TRACEPARENT_REGEXP, Transaction } from '@sentry/tracing';
-import { TransactionContext } from '@sentry/types';
+import { Integration, TransactionContext } from '@sentry/types';
 import { parseSemver } from '@sentry/utils';
 import * as http from 'http';
 import * as https from 'https';
@@ -199,7 +199,7 @@ describe('tracing', () => {
     });
     const hub = new Hub(new NodeClient(options));
 
-    const integration = new HttpIntegration() as HttpIntegration & { _wasSkipped: boolean };
+    const integration = new HttpIntegration() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,

packages/tracing/src/integrations/node/apollo.ts

@@ -27,7 +27,8 @@ export class Apollo implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * @inheritDoc

packages/tracing/src/integrations/node/express.ts

@@ -93,7 +93,8 @@ export class Express implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * Express App instance

packages/tracing/src/integrations/node/graphql.ts

@@ -19,7 +19,8 @@ export class GraphQL implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * @inheritDoc

packages/tracing/src/integrations/node/mongo.ts

@@ -105,7 +105,8 @@ export class Mongo implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   private _operations: Operation[];
   private _describeOperations?: boolean | Operation[];

packages/tracing/src/integrations/node/mysql.ts

@@ -23,7 +23,8 @@ export class Mysql implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * @inheritDoc

packages/tracing/src/integrations/node/postgres.ts

@@ -29,7 +29,8 @@ export class Postgres implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   private _usePgNative: boolean;
 

packages/tracing/src/integrations/node/prisma.ts

@@ -57,7 +57,8 @@ export class Prisma implements Integration {
   /**
    * If the integration was skipped due to internal checks.
    */
-  public _wasSkipped: boolean = false;
+  // @ts-ignore This is only used for tests
+  private _wasSkipped: boolean = false;
 
   /**
    * Prisma ORM Client Instance

packages/tracing/test/integrations/apollo.test.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { Hub, Scope } from '@sentry/core';
+import { Integration } from '@sentry/types';
 
 import { Apollo } from '../../src/integrations/node/apollo';
 import { Span } from '../../src/span';
@@ -106,7 +107,7 @@ describe('setupOnce', () => {
     const client = getTestClient({ instrumenter: 'otel' });
     const hub = new Hub(client);
 
-    const integration = new Apollo() as Apollo & { _wasSkipped: boolean };
+    const integration = new Apollo() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,

packages/tracing/test/integrations/graphql.test.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { Hub, Scope } from '@sentry/core';
+import { Integration } from '@sentry/types';
 
 import { GraphQL } from '../../src/integrations/node/graphql';
 import { Span } from '../../src/span';
@@ -59,7 +60,7 @@ describe('setupOnce', () => {
     const client = getTestClient({ instrumenter: 'otel' });
     const hub = new Hub(client);
 
-    const integration = new GraphQL() as GraphQL & { _wasSkipped: boolean };
+    const integration = new GraphQL() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,

packages/tracing/test/integrations/node/mongo.test.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { Hub, Scope } from '@sentry/core';
+import { Integration } from '@sentry/types';
 
 import { Mongo } from '../../../src/integrations/node/mongo';
 import { Span } from '../../../src/span';
@@ -117,7 +118,7 @@ describe('patchOperation()', () => {
     const client = getTestClient({ instrumenter: 'otel' });
     const hub = new Hub(client);
 
-    const integration = new Mongo() as Mongo & { _wasSkipped: boolean };
+    const integration = new Mongo() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,

packages/tracing/test/integrations/node/postgres.test.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { Hub, Scope } from '@sentry/core';
+import { Integration } from '@sentry/types';
 
 import { Postgres } from '../../../src/integrations/node/postgres';
 import { Span } from '../../../src/span';
@@ -100,7 +101,7 @@ describe('setupOnce', () => {
     const client = getTestClient({ instrumenter: 'otel' });
     const hub = new Hub(client);
 
-    const integration = new Postgres() as Postgres & { _wasSkipped: boolean };
+    const integration = new Postgres() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,

packages/tracing/test/integrations/node/prisma.test.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import { Hub, Scope } from '@sentry/core';
+import { Integration } from '@sentry/types';
 
 import { Prisma } from '../../../src/integrations/node/prisma';
 import { Span } from '../../../src/span';
@@ -64,7 +65,7 @@ describe('setupOnce', function () {
     const client = getTestClient({ instrumenter: 'otel' });
     const hub = new Hub(client);
 
-    const integration = new Prisma() as Prisma & { _wasSkipped: boolean };
+    const integration = new Prisma() as unknown as Integration & { _wasSkipped: boolean };
     integration.setupOnce(
       () => {},
       () => hub,