Skip to content

Commit 3cf5f51

Browse files
committed
ref(angular): incorporate review suggestions
* re-add pack command for ngc and legacy * rename moduleId of @sentry/utils to Sentry.util * change name of ngc build directory from `dist` to `build` * add LICENSE as an asset for `ng-packagr` * remove `prefix` property in `angular.json`
1 parent bb9fe82 commit 3cf5f51

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/angular/angular.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
{
2-
"$schema": "../.././node_modules/@angular/cli/lib/config/schema.json",
2+
"$schema": "../../node_modules/@angular/cli/lib/config/schema.json",
33
"version": 1,
44
"newProjectRoot": "projects",
55
"projects": {
66
"sentry-angular": {
77
"projectType": "library",
88
"root": ".",
99
"sourceRoot": "src",
10-
"prefix": "lib",
1110
"architect": {
1211
"build": {
1312
"builder": "@angular-devkit/build-angular:ng-packagr",

packages/angular/ng-package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"$schema": "node_modules/ng-packagr/ng-package.schema.json",
3-
"dest": "dist",
3+
"dest": "build",
44
"lib": {
55
"entryFile": "src/index.ts",
66
"umdModuleIds": {
77
"@sentry/browser": "Sentry",
8-
"@sentry/utils": "utils"
8+
"@sentry/utils": "Sentry.util"
99
}
1010
},
1111
"whitelistedNonPeerDependencies": [
@@ -15,6 +15,6 @@
1515
"tslib",
1616
"rxjs"
1717
],
18-
"assets": ["README.md"],
18+
"assets": ["README.md", "LICENSE"],
1919
"keepLifecycleScripts": true
2020
}

packages/angular/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"zone.js": "~0.10.2"
4545
},
4646
"scripts": {
47-
"build": "run-p build:ngc",
47+
"build": "yarn build:ngc",
4848
"build:legacy": "run-p build:esm build:cjs",
4949
"build:cjs": "tsc -p tsconfig.cjs.json",
5050
"build:dev": "run-s build",
@@ -67,7 +67,8 @@
6767
"lint": "run-s lint:prettier lint:eslint",
6868
"lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
6969
"lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
70-
"pack": "npm pack"
70+
"pack": "npm pack ./build",
71+
"pack:legacy": "npm pack"
7172
},
7273
"volta": {
7374
"extends": "../../package.json"

0 commit comments

Comments
 (0)