ref(core)!: Remove backwards compatible SentryCarrier type

I do not really think this is breaking or has any impact on any user code, but to be on the safe side, we can remove this in v9.

Author: mydea

packages/core/src/utils-hoist/worldwide.ts

@@ -34,19 +34,6 @@ interface SentryCarrier {
   decodePolyfill?: (input: Uint8Array) => string;
 }
 
-// TODO(v9): Clean up or remove this type
-type BackwardsCompatibleSentryCarrier = SentryCarrier & {
-  // pre-v7 hub (replaced by .stack)
-  hub: any;
-  integrations?: any[];
-  logger: any;
-  extensions?: {
-    /** Extension methods for the hub, which are bound to the current Hub instance */
-    // eslint-disable-next-line @typescript-eslint/ban-types
-    [key: string]: Function;
-  };
-};
-
 /** Internal global with common properties and Sentry extensions  */
 export type InternalGlobal = {
   navigator?: { userAgent?: string };
@@ -75,7 +62,7 @@ export type InternalGlobal = {
   _sentryDebugIds?: Record<string, string>;
   __SENTRY__: Record<Exclude<string, 'version'>, SentryCarrier> & {
     version?: string;
-  } & BackwardsCompatibleSentryCarrier;
+  };
   /**
    * Raw module metadata that is injected by bundler plugins.
    *
@@ -99,9 +86,15 @@ export const GLOBAL_OBJ = globalThis as unknown as InternalGlobal;
  * @param obj (Optional) The global object on which to look for `__SENTRY__`, if not `GLOBAL_OBJ`'s return value
  * @returns the singleton
  */
-export function getGlobalSingleton<T>(name: keyof SentryCarrier, creator: () => T, obj?: unknown): T {
-  const gbl = (obj || GLOBAL_OBJ) as InternalGlobal;
-  const __SENTRY__ = (gbl.__SENTRY__ = gbl.__SENTRY__ || {});
+export function getGlobalSingleton<T>(name: keyof SentryCarrier, creator: () => T, obj = GLOBAL_OBJ): T {
+  const __SENTRY__ = getSentryCarrierObj(obj);
   const versionedCarrier = (__SENTRY__[SDK_VERSION] = __SENTRY__[SDK_VERSION] || {});
   return versionedCarrier[name] || (versionedCarrier[name] = creator());
 }
+
+function getSentryCarrierObj(
+  obj: Omit<InternalGlobal, '__SENTRY__'> & Partial<Pick<InternalGlobal, '__SENTRY__'>>,
+): InternalGlobal['__SENTRY__'] {
+  // Set the Sentry carrier, if it does not exist yet
+  return obj.__SENTRY__ || (obj.__SENTRY__ = {});
+}