Skip to content

Commit 28983aa

Browse files
committed
use literal values in place of Severity enum values
1 parent 978aec4 commit 28983aa

File tree

15 files changed

+38
-38
lines changed

15 files changed

+38
-38
lines changed

packages/browser/src/backend.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
3939
/**
4040
* @inheritDoc
4141
*/
42-
public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
42+
public eventFromMessage(message: string, level: Severity = 'info' as Severity, hint?: EventHint): PromiseLike<Event> {
4343
return eventFromMessage(message, level, hint, this._options.attachStacktrace);
4444
}
4545

packages/browser/src/eventbuilder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export function eventFromException(
161161
const syntheticException = (hint && hint.syntheticException) || undefined;
162162
const event = eventFromUnknownInput(exception, syntheticException, attachStacktrace);
163163
addExceptionMechanism(event); // defaults to { type: 'generic', handled: true }
164-
event.level = Severity.Error;
164+
event.level = 'error' as Severity;
165165
if (hint && hint.event_id) {
166166
event.event_id = hint.event_id;
167167
}
@@ -174,7 +174,7 @@ export function eventFromException(
174174
*/
175175
export function eventFromMessage(
176176
message: string,
177-
level: Severity = Severity.Info,
177+
level: Severity = 'info' as Severity,
178178
hint?: EventHint,
179179
attachStacktrace?: boolean,
180180
): PromiseLike<Event> {

packages/browser/src/integrations/breadcrumbs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ function _fetchBreadcrumb(handlerData: { [key: string]: any }): void {
230230
{
231231
category: 'fetch',
232232
data: handlerData.fetchData,
233-
level: Severity.Error,
233+
level: 'error' as Severity,
234234
type: 'http',
235235
},
236236
{

packages/browser/src/integrations/globalhandlers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ function _installGlobalOnErrorHandler(): void {
9898
column,
9999
);
100100

101-
event.level = Severity.Error;
101+
event.level = 'error' as Severity;
102102

103103
addMechanismAndCapture(hub, error, event, 'onerror');
104104
},
@@ -144,7 +144,7 @@ function _installGlobalOnUnhandledRejectionHandler(): void {
144144
? _eventFromRejectionWithPrimitive(error)
145145
: eventFromUnknownInput(error, undefined, attachStacktrace, true);
146146

147-
event.level = Severity.Error;
147+
event.level = 'error' as Severity;
148148

149149
addMechanismAndCapture(hub, error, event, 'onunhandledrejection');
150150
return;

packages/core/test/mocks/backend.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class TestBackend extends BaseBackend<TestOptions> {
3838
});
3939
}
4040

41-
public eventFromMessage(message: string, level: Severity = Severity.Info): PromiseLike<Event> {
41+
public eventFromMessage(message: string, level: Severity = 'info' as Severity): PromiseLike<Event> {
4242
return resolvedSyncPromise({ message, level });
4343
}
4444

packages/hub/test/scope.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ describe('Scope', () => {
8585

8686
test('setLevel', () => {
8787
const scope = new Scope();
88-
scope.setLevel(Severity.Critical);
89-
expect((scope as any)._level).toEqual(Severity.Critical);
88+
scope.setLevel('critical' as Severity);
89+
expect((scope as any)._level).toEqual('critical' as Severity);
9090
});
9191

9292
test('setTransactionName', () => {
@@ -137,8 +137,8 @@ describe('Scope', () => {
137137

138138
test('chaining', () => {
139139
const scope = new Scope();
140-
scope.setLevel(Severity.Critical).setUser({ id: '1' });
141-
expect((scope as any)._level).toEqual(Severity.Critical);
140+
scope.setLevel('critical' as Severity).setUser({ id: '1' });
141+
expect((scope as any)._level).toEqual('critical' as Severity);
142142
expect((scope as any)._user).toEqual({ id: '1' });
143143
});
144144
});
@@ -202,7 +202,7 @@ describe('Scope', () => {
202202
scope.setTag('a', 'b');
203203
scope.setUser({ id: '1' });
204204
scope.setFingerprint(['abcd']);
205-
scope.setLevel(Severity.Warning);
205+
scope.setLevel('warning' as Severity);
206206
scope.setTransactionName('/abc');
207207
scope.addBreadcrumb({ message: 'test' });
208208
scope.setContext('os', { id: '1' });
@@ -294,11 +294,11 @@ describe('Scope', () => {
294294
test('scope level should have priority over event level', () => {
295295
expect.assertions(1);
296296
const scope = new Scope();
297-
scope.setLevel(Severity.Warning);
297+
scope.setLevel('warning' as Severity);
298298
const event: Event = {};
299-
event.level = Severity.Critical;
299+
event.level = 'critical' as Severity;
300300
return scope.applyToEvent(event).then(processedEvent => {
301-
expect(processedEvent!.level).toEqual(Severity.Warning);
301+
expect(processedEvent!.level).toEqual('warning' as Severity);
302302
});
303303
});
304304

@@ -410,7 +410,7 @@ describe('Scope', () => {
410410
scope.setContext('foo', { id: '1' });
411411
scope.setContext('bar', { id: '2' });
412412
scope.setUser({ id: '1337' });
413-
scope.setLevel(Severity.Info);
413+
scope.setLevel('info' as Severity);
414414
scope.setFingerprint(['foo']);
415415
scope.setRequestSession({ status: 'ok' });
416416
});
@@ -458,7 +458,7 @@ describe('Scope', () => {
458458
localScope.setContext('bar', { id: '3' });
459459
localScope.setContext('baz', { id: '4' });
460460
localScope.setUser({ id: '42' });
461-
localScope.setLevel(Severity.Warning);
461+
localScope.setLevel('warning' as Severity);
462462
localScope.setFingerprint(['bar']);
463463
(localScope as any)._requestSession = { status: 'ok' };
464464

packages/minimal/test/lib/minimal.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,8 @@ describe('Minimal', () => {
165165
const client: any = new TestClient({});
166166
const scope = getCurrentHub().pushScope();
167167
getCurrentHub().bindClient(client);
168-
scope.setLevel(Severity.Warning);
169-
expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual(Severity.Warning);
168+
scope.setLevel('warning' as Severity);
169+
expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual('warning' as Severity);
170170
});
171171
});
172172

@@ -245,16 +245,16 @@ describe('Minimal', () => {
245245

246246
test('withScope', () => {
247247
withScope(scope => {
248-
scope.setLevel(Severity.Warning);
248+
scope.setLevel('warning' as Severity);
249249
scope.setFingerprint(['1']);
250250
withScope(scope2 => {
251-
scope2.setLevel(Severity.Info);
251+
scope2.setLevel('info' as Severity);
252252
scope2.setFingerprint(['2']);
253253
withScope(scope3 => {
254254
scope3.clear();
255-
expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual(Severity.Warning);
255+
expect(global.__SENTRY__.hub._stack[1].scope._level).toEqual('warning' as Severity);
256256
expect(global.__SENTRY__.hub._stack[1].scope._fingerprint).toEqual(['1']);
257-
expect(global.__SENTRY__.hub._stack[2].scope._level).toEqual(Severity.Info);
257+
expect(global.__SENTRY__.hub._stack[2].scope._level).toEqual('info' as Severity);
258258
expect(global.__SENTRY__.hub._stack[2].scope._fingerprint).toEqual(['2']);
259259
expect(global.__SENTRY__.hub._stack[3].scope._level).toBeUndefined();
260260
});

packages/node-integration-tests/suites/public-api/addBreadcrumb/multiple_breadcrumbs/scenario.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Sentry.init({
88
Sentry.addBreadcrumb({
99
category: 'foo',
1010
message: 'bar',
11-
level: Sentry.Severity.Critical,
11+
level: 'critical' as Sentry.Severity,
1212
});
1313

1414
Sentry.addBreadcrumb({

packages/node-integration-tests/suites/public-api/addBreadcrumb/simple_breadcrumb/scenario.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Sentry.init({
88
Sentry.addBreadcrumb({
99
category: 'foo',
1010
message: 'bar',
11-
level: Sentry.Severity.Critical,
11+
level: 'critical' as Sentry.Severity,
1212
});
1313

1414
Sentry.captureMessage('test_simple');

packages/node-integration-tests/suites/public-api/captureMessage/with_level/scenario.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ Sentry.init({
55
release: '1.0',
66
});
77

8-
Sentry.captureMessage('debug_message', Sentry.Severity.Debug);
9-
Sentry.captureMessage('info_message', Sentry.Severity.Info);
10-
Sentry.captureMessage('warning_message', Sentry.Severity.Warning);
11-
Sentry.captureMessage('error_message', Sentry.Severity.Error);
12-
Sentry.captureMessage('fatal_message', Sentry.Severity.Fatal);
13-
Sentry.captureMessage('critical_message', Sentry.Severity.Critical);
14-
Sentry.captureMessage('log_message', Sentry.Severity.Log);
8+
Sentry.captureMessage('debug_message', 'debug' as Sentry.Severity);
9+
Sentry.captureMessage('info_message', 'info' as Sentry.Severity);
10+
Sentry.captureMessage('warning_message', 'warning' as Sentry.Severity);
11+
Sentry.captureMessage('error_message', 'error' as Sentry.Severity);
12+
Sentry.captureMessage('fatal_message', 'fatal' as Sentry.Severity);
13+
Sentry.captureMessage('critical_message', 'critical' as Sentry.Severity);
14+
Sentry.captureMessage('log_message', 'log' as Sentry.Severity);

packages/node/src/backend.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
2222
/**
2323
* @inheritDoc
2424
*/
25-
public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
25+
public eventFromMessage(message: string, level: Severity = 'info' as Severity, hint?: EventHint): PromiseLike<Event> {
2626
return resolvedSyncPromise(eventFromMessage(message, level, hint, this._options.attachStacktrace));
2727
}
2828

packages/node/src/eventbuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export function eventFromUnknownInput(exception: unknown, hint?: EventHint): Eve
9292
*/
9393
export function eventFromMessage(
9494
message: string,
95-
level: Severity = Severity.Info,
95+
level: Severity = 'info' as Severity,
9696
hint?: EventHint,
9797
attachStacktrace?: boolean,
9898
): Event {

packages/node/src/integrations/onuncaughtexception.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class OnUncaughtException implements Integration {
7878

7979
if (hub.getIntegration(OnUncaughtException)) {
8080
hub.withScope((scope: Scope) => {
81-
scope.setLevel(Severity.Fatal);
81+
scope.setLevel('fatal' as Severity);
8282
hub.captureException(error, {
8383
originalException: error,
8484
data: { mechanism: { handled: false, type: 'onuncaughtexception' } },

packages/serverless/src/awslambda.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ export function wrapHandler<TEvent, TResult>(
277277
timeoutWarningTimer = setTimeout(() => {
278278
withScope(scope => {
279279
scope.setTag('timeout', humanReadableTimeout);
280-
captureMessage(`Possible function timeout: ${context.functionName}`, Sentry.Severity.Warning);
280+
captureMessage(`Possible function timeout: ${context.functionName}`, 'warning' as Sentry.Severity);
281281
});
282282
}, timeoutWarningDelay);
283283
}

packages/utils/src/severity.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ function isSupportedSeverity(level: string): level is Severity {
1212
* @returns Severity
1313
*/
1414
export function severityFromString(level: SeverityLevel | string): Severity {
15-
if (level === 'warn') return Severity.Warning;
15+
if (level === 'warn') return 'warning' as Severity;
1616
if (isSupportedSeverity(level)) {
1717
return level;
1818
}
19-
return Severity.Log;
19+
return 'log' as Severity;
2020
}

0 commit comments

Comments
 (0)