Skip to content

Commit 1f28a7e

Browse files
committed
better playwright test
1 parent 3fe9cf8 commit 1f28a7e

File tree

1 file changed

+8
-1
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb

1 file changed

+8
-1
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,19 @@ sentryTest('should capture TTFB vital.', async ({ getLocalTestPath, page }) => {
99
sentryTest.skip();
1010
}
1111

12+
page.route('**', async (route) => {
13+
await new Promise((resolve) => setTimeout(resolve, 3000));
14+
route.continue()
15+
});
16+
1217
const url = await getLocalTestPath({ testDir: __dirname });
1318
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
1419

1520
expect(eventData.measurements).toBeDefined();
1621
expect(eventData.measurements?.ttfb?.value).toBeDefined();
22+
// ttfb should be greater than 0 because of the `page.route` delay. We don't want to test
23+
// the exact value here because it's not deterministic.
1724
expect(eventData.measurements?.ttfb?.value).toBeGreaterThan(0);
25+
1826
expect(eventData.measurements?.['ttfb.requestTime']?.value).toBeDefined();
19-
expect(eventData.measurements?.['ttfb.requestTime']?.value).toBeGreaterThan(0);
2027
});

0 commit comments

Comments
 (0)