Skip to content

Commit 0a54d19

Browse files
authored
test: Re-enable flaky replay tests (#11140)
closes #11136 closes #11062 closes #11137 closes #11138 closes #11139 In #11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here. Note that `Detect flaky tests / Check tests for flakiness` runs on the smaller workers, so it'll experience the same issues we had before.
1 parent 2c09292 commit 0a54d19

File tree

5 files changed

+5
-15
lines changed
  • dev-packages/browser-integration-tests/suites
    • replay/extendNetworkBreadcrumbs/fetch
    • tracing/metrics/handlers-lcp

5 files changed

+5
-15
lines changed

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
252252
]);
253253
});
254254

255-
// This test is flaky.
256-
// See https://github.com/getsentry/sentry-javascript/pull/11110
257-
sentryTest.skip('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
255+
sentryTest('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
258256
if (shouldSkipReplayTest()) {
259257
sentryTest.skip();
260258
}

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,7 @@ sentryTest.skip('captures request body size when body is sent', async ({ getLoca
9595
]);
9696
});
9797

98-
// This test is flaky.
99-
// See https://github.com/getsentry/sentry-javascript/pull/11110
100-
sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
98+
sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
10199
if (shouldSkipReplayTest()) {
102100
sentryTest.skip();
103101
}

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
157157
]);
158158
});
159159

160-
// This test is flaky so it's skipped for now
161-
// See https://github.com/getsentry/sentry-javascript/issues/11139
162-
sentryTest.skip('does not capture response headers if URL does not match', async ({ getLocalTestPath, page }) => {
160+
sentryTest('does not capture response headers if URL does not match', async ({ getLocalTestPath, page }) => {
163161
if (shouldSkipReplayTest()) {
164162
sentryTest.skip();
165163
}

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
188188
]);
189189
});
190190

191-
// This test is flaky so it's skipped for now
192-
// See https://github.com/getsentry/sentry-javascript/issues/11137
193-
sentryTest.skip('captures response size from non-text response body', async ({ getLocalTestPath, page }) => {
191+
sentryTest('captures response size from non-text response body', async ({ getLocalTestPath, page }) => {
194192
if (shouldSkipReplayTest()) {
195193
sentryTest.skip();
196194
}

dev-packages/browser-integration-tests/suites/tracing/metrics/handlers-lcp/test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../.
77

88
const bundle = process.env.PW_BUNDLE || '';
99

10-
// This test is flaky so it's skipped for now
11-
// See https://github.com/getsentry/sentry-javascript/issues/11138
12-
sentryTest.skip(
10+
sentryTest(
1311
'should capture metrics for LCP instrumentation handlers',
1412
async ({ browserName, getLocalTestPath, page }) => {
1513
// This uses a utility that is not exported in CDN bundles

0 commit comments

Comments
 (0)