Skip to content

Commit 00a4db7

Browse files
committed
fix safari 14.4 ios failing test
1 parent f5822eb commit 00a4db7

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

packages/browser-utils/src/metrics/web-vitals/getINP.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,8 @@ export const onINP = (onReport: (metric: INPMetric) => void, opts: INPReportOpts
121121
// because some browsers we still support (Safari <14.4) don't fully support
122122
// `visibilitychange` or have known bugs w.r.t the `visibilitychange` event.
123123
onHidden(() => {
124-
if (WINDOW.document?.visibilityState === 'hidden') {
125-
handleEntries(po.takeRecords() as INPMetric['entries']);
126-
report(true);
127-
}
124+
handleEntries(po.takeRecords() as INPMetric['entries']);
125+
report(true);
128126
});
129127
}
130128
});

packages/browser-utils/src/metrics/web-vitals/lib/whenIdleOrHidden.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616

1717
import { WINDOW } from '../../../types.js';
18+
import { onHidden } from './onHidden.js';
1819
import { runOnce } from './runOnce.js';
1920

2021
/**
@@ -32,6 +33,9 @@ export const whenIdleOrHidden = (cb: () => void) => {
3233
// eslint-disable-next-line no-param-reassign
3334
cb = runOnce(cb);
3435
rIC(cb);
35-
WINDOW.document?.addEventListener('visibilitychange', cb, { once: true });
36+
// sentry: we use onHidden instead of directly listening to visibilitychange
37+
// because some browsers we still support (Safari <14.4) don't fully support
38+
// `visibilitychange` or have known bugs w.r.t the `visibilitychange` event.
39+
onHidden(cb);
3640
}
3741
};

0 commit comments

Comments
 (0)