From 1efb5baf7e539beb0a6f2fc9abcb1418eaeb500c Mon Sep 17 00:00:00 2001 From: Mike Lambert Date: Thu, 27 Oct 2016 04:35:07 -0400 Subject: [PATCH] Stop passing getApplicationContext() in to the constructor. It's not necessary, and can be derived from the ReactApplicationContext object. --- README.md | 2 +- .../main/java/io/fullstack/firestack/FirestackPackage.java | 5 ++--- package.json | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 98d56b3..17ce5d9 100644 --- a/README.md +++ b/README.md @@ -144,7 +144,7 @@ public class MainApplication extends Application implements ReactApplication { protected List getPackages() { return Arrays.asList( new MainReactPackage(), - new FirestackPackage(getApplicationContext()) + new FirestackPackage() ); } }; diff --git a/android/src/main/java/io/fullstack/firestack/FirestackPackage.java b/android/src/main/java/io/fullstack/firestack/FirestackPackage.java index 5596030..ea5927d 100644 --- a/android/src/main/java/io/fullstack/firestack/FirestackPackage.java +++ b/android/src/main/java/io/fullstack/firestack/FirestackPackage.java @@ -15,8 +15,7 @@ public class FirestackPackage implements ReactPackage { private Context mContext; - public FirestackPackage(Context ctx) { - mContext = ctx; + public FirestackPackage() { } /** * @param reactContext react application context that can be used to create modules @@ -26,7 +25,7 @@ public FirestackPackage(Context ctx) { public List createNativeModules(ReactApplicationContext reactContext) { List modules = new ArrayList<>(); - modules.add(new FirestackModule(reactContext, mContext)); + modules.add(new FirestackModule(reactContext, reactContext.getBaseContext())); modules.add(new FirestackAuthModule(reactContext)); modules.add(new FirestackDatabaseModule(reactContext)); modules.add(new FirestackAnalyticsModule(reactContext)); diff --git a/package.json b/package.json index cc53350..b591c2c 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "project": "ios/Firestack.xcodeproj" }, "android": { - "packageInstance": "new FirestackPackage(getApplicationContext())" + "packageInstance": "new FirestackPackage()" } }, "devDependencies": {