bug #520 Autocomplete choice label (weaverryan)

This PR was merged into the 2.x branch.

Discussion
----------

Autocomplete choice label

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | none
| License       | MIT

If your autocomplete field does not specify `choice_label`, this creates a choice label situation that we apparently weren't handling yet:

<img width="973" alt="Screen Shot 2022-11-03 at 10 16 58 AM" src="https://user-images.githubusercontent.com/121003/199744820-10196553-21dc-4a01-a134-9133aa8cea4f.png">

Fixed with test.

Commits
-------

7dd8c9d Fixing a bug where noi choice_label + autocomplete caused an error

Author: fullstackdeveloperwebapp

src/Autocomplete/src/Form/WrappedEntityTypeAutocompleter.php

@@ -4,6 +4,7 @@
 
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\QueryBuilder;
+use Symfony\Component\Form\ChoiceList\Factory\Cache\ChoiceLabel;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
@@ -79,6 +80,10 @@ public function getLabel(object $entity): string
             return $this->propertyAccessor->getValue($entity, $choiceLabel);
         }
 
+        if ($choiceLabel instanceof ChoiceLabel) {
+            $choiceLabel = $choiceLabel->getOption();
+        }
+
         // 0 hardcoded as the "index", should not be relevant
         return $choiceLabel($entity, 0, $this->getValue($entity));
     }

src/Autocomplete/tests/Fixtures/Entity/Category.php

@@ -72,4 +72,9 @@ public function removeProduct(Product $product): self
 
         return $this;
     }
+
+    public function __toString(): string
+    {
+        return $this->getName();
+    }
 }

src/Autocomplete/tests/Fixtures/Form/CategoryNoChoiceLabelAutocompleteType.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Symfony\UX\Autocomplete\Tests\Fixtures\Form;
+
+use Doctrine\ORM\EntityRepository;
+use Symfony\UX\Autocomplete\Tests\Fixtures\Entity\Category;
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\HttpFoundation\RequestStack;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+use Symfony\Component\Security\Core\Security;
+use Symfony\UX\Autocomplete\Form\AsEntityAutocompleteField;
+use Symfony\UX\Autocomplete\Form\ParentEntityAutocompleteType;
+
+#[AsEntityAutocompleteField]
+class CategoryNoChoiceLabelAutocompleteType extends AbstractType
+{
+    public function configureOptions(OptionsResolver $resolver)
+    {
+        $resolver->setDefaults([
+            'class' => Category::class,
+            'placeholder' => 'What should we eat?',
+        ]);
+    }
+
+    public function getParent(): string
+    {
+        return ParentEntityAutocompleteType::class;
+    }
+}

src/Autocomplete/tests/Functional/FieldAutocompleterTest.php

@@ -18,7 +18,6 @@
 use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 
-// tests CategoryAutocompleteType
 class FieldAutocompleterTest extends KernelTestCase
 {
     use Factories;
@@ -90,4 +89,16 @@ public function testItCheckMaxResultsOption(): void
             ->assertJsonMatches('length(results)', 5)
         ;
     }
+
+    public function testItWorksWithoutAChoiceLabel(): void
+    {
+        CategoryFactory::createMany(5, ['name' => 'foo']);
+
+        $this->browser()
+            ->throwExceptions()
+            ->get('/test/autocomplete/category_no_choice_label_autocomplete_type?query=foo')
+            ->assertSuccessful()
+            ->assertJsonMatches('length(results)', 5)
+        ;
+    }
 }