Fixes Allow linter activation without extension restart #296

Author: gnikit

CHANGELOG.md

@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Fixes linting regex to capture a wider spectrum of errors
   ([#295](https://github.com/krvajal/vscode-fortran-support/issues/295))
+- Fixes linter activation from `Disabled` to some compiler `X` without having
+  to restart the extension
+  ([#296](https://github.com/krvajal/vscode-fortran-support/issues/296))
 
 ### Changed
 

src/extension.ts

@@ -34,11 +34,10 @@ export async function activate(context: vscode.ExtensionContext) {
   loggingService.logInfo(`Hover set to: ${hoverType}`);
   loggingService.logInfo(`Symbols set to: ${symbolsType}`);
 
-  if (linterType !== 'Disabled') {
-    const linter = new FortranLintingProvider(loggingService);
-    linter.activate(context.subscriptions);
-    vscode.languages.registerCodeActionsProvider(FortranDocumentSelector(), linter);
-  }
+  // Linter is always activated but will only lint if compiler !== Disabled
+  const linter = new FortranLintingProvider(loggingService);
+  linter.activate(context.subscriptions);
+  vscode.languages.registerCodeActionsProvider(FortranDocumentSelector(), linter);
 
   if (formatterType !== 'Disabled') {
     const disposable: vscode.Disposable = vscode.languages.registerDocumentFormattingEditProvider(

src/features/linter-provider.ts

@@ -52,6 +52,9 @@ export class FortranLintingProvider {
   }
 
   private doModernFortranLint(textDocument: vscode.TextDocument) {
+    // Only lint if a compiler is specified
+    const config = vscode.workspace.getConfiguration('fortran.linter');
+    if (config.get<string>('fortran.linter.compiler') === 'Disabled') return;
     // Only lint Fortran (free, fixed) format files
     if (
       !FortranDocumentSelector().some(e => e.scheme === textDocument.uri.scheme) ||