Skip to content

Commit fda7ffb

Browse files
[Impeller] disable no decal metal test. (flutter#166771)
Fixes flutter#166020 This test is invalid because the renderer assumes metal/vulkan will always have decal support (they do, its in base 1.0 for both). DIsabling decal causes this test to attempt to use a GLES only shader that is not available on the metal backend.
1 parent 41c32eb commit fda7ffb

File tree

1 file changed

+0
-51
lines changed

1 file changed

+0
-51
lines changed

engine/src/flutter/impeller/display_list/aiks_dl_blur_unittests.cc

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,57 +1253,6 @@ TEST_P(AiksTest, BlurredRectangleWithShader) {
12531253
ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
12541254
}
12551255

1256-
TEST_P(AiksTest, GaussianBlurWithoutDecalSupport) {
1257-
if (GetParam() != PlaygroundBackend::kMetal) {
1258-
GTEST_SKIP()
1259-
<< "This backend doesn't yet support setting device capabilities.";
1260-
}
1261-
if (!WillRenderSomething()) {
1262-
// Sometimes these tests are run without playgrounds enabled which is
1263-
// pointless for this test since we are asserting that
1264-
// `SupportsDecalSamplerAddressMode` is called.
1265-
GTEST_SKIP() << "This test requires playgrounds.";
1266-
}
1267-
1268-
std::shared_ptr<const Capabilities> old_capabilities =
1269-
GetContext()->GetCapabilities();
1270-
auto mock_capabilities = std::make_shared<MockCapabilities>();
1271-
EXPECT_CALL(*mock_capabilities, SupportsDecalSamplerAddressMode())
1272-
.Times(::testing::AtLeast(1))
1273-
.WillRepeatedly(::testing::Return(false));
1274-
FLT_FORWARD(mock_capabilities, old_capabilities, GetDefaultColorFormat);
1275-
FLT_FORWARD(mock_capabilities, old_capabilities, GetDefaultStencilFormat);
1276-
FLT_FORWARD(mock_capabilities, old_capabilities,
1277-
GetDefaultDepthStencilFormat);
1278-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsOffscreenMSAA);
1279-
FLT_FORWARD(mock_capabilities, old_capabilities,
1280-
SupportsImplicitResolvingMSAA);
1281-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsReadFromResolve);
1282-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsFramebufferFetch);
1283-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsSSBO);
1284-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsCompute);
1285-
FLT_FORWARD(mock_capabilities, old_capabilities,
1286-
SupportsTextureToTextureBlits);
1287-
FLT_FORWARD(mock_capabilities, old_capabilities, GetDefaultGlyphAtlasFormat);
1288-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsTriangleFan);
1289-
FLT_FORWARD(mock_capabilities, old_capabilities, SupportsPrimitiveRestart);
1290-
ASSERT_TRUE(SetCapabilities(mock_capabilities).ok());
1291-
1292-
auto texture = DlImageImpeller::Make(CreateTextureForFixture("boston.jpg"));
1293-
1294-
DisplayListBuilder builder;
1295-
builder.Scale(GetContentScale().x * 0.5, GetContentScale().y * 0.5);
1296-
1297-
DlPaint paint;
1298-
paint.setColor(DlColor::kBlack());
1299-
builder.DrawPaint(paint);
1300-
1301-
auto blur_filter = DlImageFilter::MakeBlur(20, 20, DlTileMode::kDecal);
1302-
paint.setImageFilter(blur_filter);
1303-
builder.DrawImage(texture, DlPoint(200, 200), {}, &paint);
1304-
ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
1305-
}
1306-
13071256
// This addresses a bug where tiny blurs could result in mip maps that beyond
13081257
// the limits for the textures used for blurring.
13091258
// See also: b/323402168

0 commit comments

Comments
 (0)