Skip to content

Commit a66be0e

Browse files
author
Chris Yang
authored
[webview_flutter] [webview_flutter_wkwebview]Fix race condition in flaky test (flutter#5068)
Same fix as flutter/packages#5037
1 parent 434b348 commit a66be0e

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

packages/webview_flutter/webview_flutter/example/integration_test/legacy/webview_flutter_test.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,9 @@ Future<void> main() async {
144144
'test_header': 'flutter_test_header'
145145
};
146146
await controller.loadUrl(headersUrl, headers: headers);
147-
final String? currentUrl = await controller.currentUrl();
148-
expect(currentUrl, headersUrl);
149147

150-
await pageStarts.stream.firstWhere((String url) => url == currentUrl);
151-
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
148+
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
149+
await pageLoads.stream.firstWhere((String url) => url == headersUrl);
152150

153151
final String content = await controller
154152
.runJavascriptReturningResult('document.documentElement.innerText');

packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,9 @@ Future<void> main() async {
170170
'test_header': 'flutter_test_header'
171171
};
172172
await controller.loadUrl(headersUrl, headers: headers);
173-
final String? currentUrl = await controller.currentUrl();
174-
expect(currentUrl, headersUrl);
175173

176-
await pageStarts.stream.firstWhere((String url) => url == currentUrl);
177-
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
174+
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
175+
await pageLoads.stream.firstWhere((String url) => url == headersUrl);
178176

179177
final String content = await controller
180178
.runJavascriptReturningResult('document.documentElement.innerText');

0 commit comments

Comments
 (0)