Skip to content

Commit 8d1acdd

Browse files
[google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter#7609)
Disables tests that are suddenly flaking very badly and keeping the tree closed. Tracked in flutter#154826
1 parent b4e0fc1 commit 8d1acdd

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,8 @@ Future<void> main() async {
568568
});
569569
},
570570
// Scroll position is currently not implemented for macOS.
571-
skip: Platform.isMacOS);
571+
// Flakes on iOS: https://github.com/flutter/flutter/issues/154826
572+
skip: Platform.isMacOS || Platform.isIOS);
572573

573574
group('NavigationDelegate', () {
574575
const String blankPage = '<!DOCTYPE html><head></head><body></body></html>';

packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,8 @@ Future<void> main() async {
893893
});
894894
},
895895
// Scroll position is currently not implemented for macOS.
896-
skip: Platform.isMacOS);
896+
// Flakes on iOS: https://github.com/flutter/flutter/issues/154826
897+
skip: Platform.isMacOS || Platform.isIOS);
897898

898899
group('NavigationDelegate', () {
899900
const String blankPage = '<!DOCTYPE html><head></head><body></body></html>';

packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -808,7 +808,8 @@ Future<void> main() async {
808808
});
809809
},
810810
// Scroll position is currently not implemented for macOS.
811-
skip: Platform.isMacOS);
811+
// Flakes on iOS: https://github.com/flutter/flutter/issues/154826
812+
skip: Platform.isMacOS || Platform.isIOS);
812813

813814
group('NavigationDelegate', () {
814815
const String blankPage = '<!DOCTYPE html><head></head><body></body></html>';

0 commit comments

Comments
 (0)