Merge pull request #57 from CoreyCole/patch-1

cloudwebrtc · web-flow · commit 4849ba59ae0e · 2020-01-03T09:38:04.000+08:00
fix(signaling): save reference to peer connection before removing it
diff --git a/lib/src/call_sample/signaling.dart b/lib/src/call_sample/signaling.dart
@@ -201,18 +201,16 @@ class Signaling {
       case 'leave':
         {
           var id = data;
-          _peerConnections.remove(id);
+          var pc = _peerConnections.remove(id);
           _dataChannels.remove(id);
 
           if (_localStream != null) {
             _localStream.dispose();
             _localStream = null;
           }
 
-          var pc = _peerConnections[id];
           if (pc != null) {
             pc.close();
-            _peerConnections.remove(id);
           }
           this._sessionId = null;
           if (this.onStateChange != null) {

Original file line number	Diff line number	Diff line change
`@@ -201,18 +201,16 @@ class Signaling {`
`201`	`201`	`case 'leave':`
`202`	`202`	`{`
`203`	`203`	`var id = data;`
`204`		`- _peerConnections.remove(id);`
	`204`	`+ var pc = _peerConnections.remove(id);`
`205`	`205`	`_dataChannels.remove(id);`
`206`	`206`
`207`	`207`	`if (_localStream != null) {`
`208`	`208`	`_localStream.dispose();`
`209`	`209`	`_localStream = null;`
`210`	`210`	`}`
`211`	`211`
`212`		`- var pc = _peerConnections[id];`
`213`	`212`	`if (pc != null) {`
`214`	`213`	`pc.close();`
`215`		`- _peerConnections.remove(id);`
`216`	`214`	`}`
`217`	`215`	`this._sessionId = null;`
`218`	`216`	`if (this.onStateChange != null) {`