From a5fe378c266539f156a7cf6cd773374bdea4c845 Mon Sep 17 00:00:00 2001 From: Morgan Chen Date: Wed, 8 Nov 2023 11:40:52 -0800 Subject: [PATCH 1/3] fix broken array-in snippets --- firestore-next/test.firestore.js | 4 ++-- firestore/test.firestore.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/firestore-next/test.firestore.js b/firestore-next/test.firestore.js index c961af9d..5925bcbe 100644 --- a/firestore-next/test.firestore.js +++ b/firestore-next/test.firestore.js @@ -892,7 +892,7 @@ describe("firestore", () => { const { query, where } = require("firebase/firestore"); const q = query(citiesRef, - where('regions', 'array-contains-any', ['west_coast', 'east_coast'])); + where('regions', 'array-contains-any', [['west_coast'], ['east_coast']])); // [END array_contains_any_filter] }); @@ -920,7 +920,7 @@ describe("firestore", () => { // [START in_filter_with_array] const { query, where } = require("firebase/firestore"); - const q = query(citiesRef, where('regions', 'in', [['west_coast', 'east_coast']])); + const q = query(citiesRef, where('regions', 'in', [['west_coast'], ['east_coast']])); // [END in_filter_with_array] } }); diff --git a/firestore/test.firestore.js b/firestore/test.firestore.js index ec89172e..7d820f0b 100644 --- a/firestore/test.firestore.js +++ b/firestore/test.firestore.js @@ -877,7 +877,7 @@ describe("firestore", () => { const citiesRef = db.collection('cities'); // [START array_contains_any_filter] citiesRef.where('regions', 'array-contains-any', - ['west_coast', 'east_coast']); + [['west_coast'], ['east_coast']]); // [END array_contains_any_filter] }); @@ -893,7 +893,7 @@ describe("firestore", () => { // [START in_filter_with_array] citiesRef.where('regions', 'in', - [['west_coast', 'east_coast']]); + [['west_coast'], ['east_coast']]); // [END in_filter_with_array] }); From b2fea1814bfbb235d96f81aea3b3d5fd94cb13a5 Mon Sep 17 00:00:00 2001 From: Morgan Chen Date: Wed, 8 Nov 2023 12:51:20 -0800 Subject: [PATCH 2/3] npm run snippets --- .../firestore-next/test-firestore/array_contains_any_filter.js | 2 +- snippets/firestore-next/test-firestore/in_filter_with_array.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/snippets/firestore-next/test-firestore/array_contains_any_filter.js b/snippets/firestore-next/test-firestore/array_contains_any_filter.js index 3ee6e4d9..c263ec7b 100644 --- a/snippets/firestore-next/test-firestore/array_contains_any_filter.js +++ b/snippets/firestore-next/test-firestore/array_contains_any_filter.js @@ -8,5 +8,5 @@ import { query, where } from "firebase/firestore"; const q = query(citiesRef, - where('regions', 'array-contains-any', ['west_coast', 'east_coast'])); + where('regions', 'array-contains-any', [['west_coast'], ['east_coast']])); // [END array_contains_any_filter_modular] \ No newline at end of file diff --git a/snippets/firestore-next/test-firestore/in_filter_with_array.js b/snippets/firestore-next/test-firestore/in_filter_with_array.js index ebe6f18b..190e9dfe 100644 --- a/snippets/firestore-next/test-firestore/in_filter_with_array.js +++ b/snippets/firestore-next/test-firestore/in_filter_with_array.js @@ -7,5 +7,5 @@ // [START in_filter_with_array_modular] import { query, where } from "firebase/firestore"; -const q = query(citiesRef, where('regions', 'in', [['west_coast', 'east_coast']])); +const q = query(citiesRef, where('regions', 'in', [['west_coast'], ['east_coast']])); // [END in_filter_with_array_modular] \ No newline at end of file From 9dc11d75b7388ade1b29c5b77cc8ff3606d467ad Mon Sep 17 00:00:00 2001 From: Morgan Chen Date: Wed, 8 Nov 2023 14:58:40 -0800 Subject: [PATCH 3/3] revert array contians anay changes --- firestore-next/test.firestore.js | 2 +- firestore/test.firestore.js | 2 +- .../firestore-next/test-firestore/array_contains_any_filter.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/firestore-next/test.firestore.js b/firestore-next/test.firestore.js index 5925bcbe..969c1654 100644 --- a/firestore-next/test.firestore.js +++ b/firestore-next/test.firestore.js @@ -892,7 +892,7 @@ describe("firestore", () => { const { query, where } = require("firebase/firestore"); const q = query(citiesRef, - where('regions', 'array-contains-any', [['west_coast'], ['east_coast']])); + where('regions', 'array-contains-any', ['west_coast', 'east_coast'])); // [END array_contains_any_filter] }); diff --git a/firestore/test.firestore.js b/firestore/test.firestore.js index 7d820f0b..20032d36 100644 --- a/firestore/test.firestore.js +++ b/firestore/test.firestore.js @@ -877,7 +877,7 @@ describe("firestore", () => { const citiesRef = db.collection('cities'); // [START array_contains_any_filter] citiesRef.where('regions', 'array-contains-any', - [['west_coast'], ['east_coast']]); + ['west_coast', 'east_coast']); // [END array_contains_any_filter] }); diff --git a/snippets/firestore-next/test-firestore/array_contains_any_filter.js b/snippets/firestore-next/test-firestore/array_contains_any_filter.js index c263ec7b..3ee6e4d9 100644 --- a/snippets/firestore-next/test-firestore/array_contains_any_filter.js +++ b/snippets/firestore-next/test-firestore/array_contains_any_filter.js @@ -8,5 +8,5 @@ import { query, where } from "firebase/firestore"; const q = query(citiesRef, - where('regions', 'array-contains-any', [['west_coast'], ['east_coast']])); + where('regions', 'array-contains-any', ['west_coast', 'east_coast'])); // [END array_contains_any_filter_modular] \ No newline at end of file