Skip to content

Commit 2b97722

Browse files
authored
Fix nesting issue in collection group query sample (#280)
1 parent 69c85ab commit 2b97722

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

firestore-next/test.firestore.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,48 +1095,48 @@ describe("firestore", () => {
10951095
describe('collectionGroup(landmarks)', () => {
10961096
it("should setup example data", async () => {
10971097
// [START fs_collection_group_query_data_setup]
1098-
const { collection, doc, setDoc } = require("firebase/firestore");
1098+
const { collection, addDoc } = require("firebase/firestore");
10991099

11001100
const citiesRef = collection(db, 'cities');
11011101

11021102
await Promise.all([
1103-
setDoc(doc(citiesRef, 'SF', 'landmarks'), {
1103+
addDoc(collection(citiesRef, 'SF', 'landmarks'), {
11041104
name: 'Golden Gate Bridge',
11051105
type: 'bridge'
11061106
}),
1107-
setDoc(doc(citiesRef, 'SF', 'landmarks'), {
1107+
addDoc(collection(citiesRef, 'SF', 'landmarks'), {
11081108
name: 'Legion of Honor',
11091109
type: 'museum'
11101110
}),
1111-
setDoc(doc(citiesRef, 'LA', 'landmarks'), {
1111+
addDoc(collection(citiesRef, 'LA', 'landmarks'), {
11121112
name: 'Griffith Park',
11131113
type: 'park'
11141114
}),
1115-
setDoc(doc(citiesRef, 'LA', 'landmarks'), {
1115+
addDoc(collection(citiesRef, 'LA', 'landmarks'), {
11161116
name: 'The Getty',
11171117
type: 'museum'
11181118
}),
1119-
setDoc(doc(citiesRef, 'DC', 'landmarks'), {
1119+
addDoc(collection(citiesRef, 'DC', 'landmarks'), {
11201120
name: 'Lincoln Memorial',
11211121
type: 'memorial'
11221122
}),
1123-
setDoc(doc(citiesRef, 'DC', 'landmarks'), {
1123+
addDoc(collection(citiesRef, 'DC', 'landmarks'), {
11241124
name: 'National Air and Space Museum',
11251125
type: 'museum'
11261126
}),
1127-
setDoc(doc(citiesRef, 'TOK', 'landmarks'), {
1127+
addDoc(collection(citiesRef, 'TOK', 'landmarks'), {
11281128
name: 'Ueno Park',
11291129
type: 'park'
11301130
}),
1131-
setDoc(doc(citiesRef, 'TOK', 'landmarks'), {
1131+
addDoc(collection(citiesRef, 'TOK', 'landmarks'), {
11321132
name: 'National Museum of Nature and Science',
11331133
type: 'museum'
11341134
}),
1135-
setDoc(doc(citiesRef, 'BJ', 'landmarks'), {
1135+
addDoc(collection(citiesRef, 'BJ', 'landmarks'), {
11361136
name: 'Jingshan Park',
11371137
type: 'park'
11381138
}),
1139-
setDoc(doc(citiesRef, 'BJ', 'landmarks'), {
1139+
addDoc(collection(citiesRef, 'BJ', 'landmarks'), {
11401140
name: 'Beijing Ancient Observatory',
11411141
type: 'museum'
11421142
})

snippets/firestore-next/test-firestore/fs_collection_group_query_data_setup.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,48 +5,48 @@
55
// 'npm run snippets'.
66

77
// [START fs_collection_group_query_data_setup_modular]
8-
import { collection, doc, setDoc } from "firebase/firestore";
8+
import { collection, addDoc } from "firebase/firestore";
99

1010
const citiesRef = collection(db, 'cities');
1111

1212
await Promise.all([
13-
setDoc(doc(citiesRef, 'SF', 'landmarks'), {
13+
addDoc(collection(citiesRef, 'SF', 'landmarks'), {
1414
name: 'Golden Gate Bridge',
1515
type: 'bridge'
1616
}),
17-
setDoc(doc(citiesRef, 'SF', 'landmarks'), {
17+
addDoc(collection(citiesRef, 'SF', 'landmarks'), {
1818
name: 'Legion of Honor',
1919
type: 'museum'
2020
}),
21-
setDoc(doc(citiesRef, 'LA', 'landmarks'), {
21+
addDoc(collection(citiesRef, 'LA', 'landmarks'), {
2222
name: 'Griffith Park',
2323
type: 'park'
2424
}),
25-
setDoc(doc(citiesRef, 'LA', 'landmarks'), {
25+
addDoc(collection(citiesRef, 'LA', 'landmarks'), {
2626
name: 'The Getty',
2727
type: 'museum'
2828
}),
29-
setDoc(doc(citiesRef, 'DC', 'landmarks'), {
29+
addDoc(collection(citiesRef, 'DC', 'landmarks'), {
3030
name: 'Lincoln Memorial',
3131
type: 'memorial'
3232
}),
33-
setDoc(doc(citiesRef, 'DC', 'landmarks'), {
33+
addDoc(collection(citiesRef, 'DC', 'landmarks'), {
3434
name: 'National Air and Space Museum',
3535
type: 'museum'
3636
}),
37-
setDoc(doc(citiesRef, 'TOK', 'landmarks'), {
37+
addDoc(collection(citiesRef, 'TOK', 'landmarks'), {
3838
name: 'Ueno Park',
3939
type: 'park'
4040
}),
41-
setDoc(doc(citiesRef, 'TOK', 'landmarks'), {
41+
addDoc(collection(citiesRef, 'TOK', 'landmarks'), {
4242
name: 'National Museum of Nature and Science',
4343
type: 'museum'
4444
}),
45-
setDoc(doc(citiesRef, 'BJ', 'landmarks'), {
45+
addDoc(collection(citiesRef, 'BJ', 'landmarks'), {
4646
name: 'Jingshan Park',
4747
type: 'park'
4848
}),
49-
setDoc(doc(citiesRef, 'BJ', 'landmarks'), {
49+
addDoc(collection(citiesRef, 'BJ', 'landmarks'), {
5050
name: 'Beijing Ancient Observatory',
5151
type: 'museum'
5252
})

0 commit comments

Comments
 (0)