Skip to content

Commit 99d5ae2

Browse files
authored
Fix the reCaptcha errors and aggregate query error (#27)
* Fix the reCaptcha errors and aggregate query error Fixes Bug in Firestore count_aggregate_query snippets #24 and Fixes Bug in phone_auth_web_with_recaptcha snippet #25 * upgrade kotlin, gradle, and java * upgrade kotlin, gradle, and java
1 parent fdb1bd8 commit 99d5ae2

File tree

7 files changed

+578
-316
lines changed

7 files changed

+578
-316
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
name: "Install Java"
3030
with:
3131
distribution: 'temurin'
32-
java-version: '11'
32+
java-version: '17'
3333

3434
- name: "Install Flutter"
3535
run: |

packages/firebase_snippets_app/android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
buildscript {
2-
ext.kotlin_version = '1.6.10'
2+
ext.kotlin_version = '1.7.10'
33
repositories {
44
google()
55
mavenCentral()
66
}
77

88
dependencies {
9-
classpath 'com.android.tools.build:gradle:4.1.0'
9+
classpath 'com.android.tools.build:gradle:7.2.0'
1010
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
1111
classpath 'com.google.gms:google-services:4.3.10'
1212
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.1'
@@ -29,6 +29,6 @@ subprojects {
2929
project.evaluationDependsOn(':app')
3030
}
3131

32-
task clean(type: Delete) {
32+
tasks.register("clean", Delete) {
3333
delete rootProject.buildDir
3434
}

packages/firebase_snippets_app/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip

packages/firebase_snippets_app/lib/snippets/auth.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import 'dart:math';
55

66
import 'package:crypto/crypto.dart';
77
import 'package:firebase_auth/firebase_auth.dart';
8+
import 'package:firebase_auth_platform_interface/firebase_auth_platform_interface.dart';
89
import 'package:firebase_snippets_app/snippets/snippet_base.dart';
910
import 'package:flutter/foundation.dart';
1011
import 'package:google_sign_in/google_sign_in.dart';
@@ -576,6 +577,7 @@ class AuthenticationSnippets implements DocSnippet {
576577
await auth.signInWithPhoneNumber(
577578
'+44 7123 123 456',
578579
RecaptchaVerifier(
580+
auth: FirebaseAuthPlatform.instance,
579581
container: 'recaptcha',
580582
size: RecaptchaVerifierSize.compact,
581583
theme: RecaptchaVerifierTheme.dark,
@@ -584,6 +586,7 @@ class AuthenticationSnippets implements DocSnippet {
584586

585587
// [START phone_auth_verify_recaptcha]
586588
RecaptchaVerifier(
589+
auth: FirebaseAuthPlatform.instance,
587590
onSuccess: () => print('reCAPTCHA Completed!'),
588591
onError: (FirebaseAuthException error) => print(error),
589592
onExpired: () => print('reCAPTCHA Expired!'),

packages/firebase_snippets_app/lib/snippets/firestore.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -824,8 +824,8 @@ class FirestoreSnippets extends DocSnippet {
824824
void aggregationQuery_count() {
825825
// [START count_aggregate_collection]
826826
// Returns number of documents in users collection
827-
db.collection("users").count().then(
828-
(res) => print(res.data().count),
827+
db.collection("users").count().get().then(
828+
(res) => print(res.count),
829829
onError: (e) => print("Error completing: $e"),
830830
);
831831
// [END count_aggregate_collection]
@@ -834,8 +834,8 @@ class FirestoreSnippets extends DocSnippet {
834834
void aggregationQuery_count2() {
835835
// [START count_aggregate_query]
836836
// This also works with collectionGroup queries.
837-
db.collection("users").where("age", isGreaterThan: 10).count().then(
838-
(res) => print(res.data().count),
837+
db.collection("users").where("age", isGreaterThan: 10).count().get().then(
838+
(res) => print(res.count),
839839
onError: (e) => print("Error completing: $e"),
840840
);
841841
// [END count_aggregate_query]

0 commit comments

Comments
 (0)