From 662379336e0c137e975c6389e2b791b01eb51bf3 Mon Sep 17 00:00:00 2001 From: Grant Anderson Date: Tue, 8 Sep 2020 10:34:52 -0700 Subject: [PATCH 1/2] InvalidArgumentException - Issue #302 add InvalidArgumentException use statement to JWK.php --- src/JWK.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/JWK.php b/src/JWK.php index 1d273917..7632f4a4 100644 --- a/src/JWK.php +++ b/src/JWK.php @@ -3,6 +3,7 @@ namespace Firebase\JWT; use DomainException; +use InvalidArgumentException; use UnexpectedValueException; /** From f496ec77da3ecd7ebbc2184d8829b77fab5773b0 Mon Sep 17 00:00:00 2001 From: Grant Anderson Date: Tue, 8 Sep 2020 11:02:03 -0700 Subject: [PATCH 2/2] Update JWKTest.php Added tests to validate. Tests fail on master. --- tests/JWKTest.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/JWKTest.php b/tests/JWKTest.php index 3d317d55..b8b67540 100644 --- a/tests/JWKTest.php +++ b/tests/JWKTest.php @@ -43,6 +43,20 @@ public function testParseJwkKeySet() self::$keys = $keys; } + public function testParseJwkKey_empty() + { + $this->setExpectedException('InvalidArgumentException', 'JWK must not be empty'); + + JWK::parseKeySet(array('keys' => array(array()))); + } + + public function testParseJwkKeySet_empty() + { + $this->setExpectedException('InvalidArgumentException', 'JWK Set did not contain any keys'); + + JWK::parseKeySet(array('keys' => array())); + } + /** * @depends testParseJwkKeySet */