fix: use property_exists for checking key id (#395)

bshaffer · web-flow · commit 7e0a273c602f · 2022-02-07T07:04:10.000-08:00
diff --git a/src/JWT.php b/src/JWT.php
@@ -111,7 +111,7 @@ public static function decode($jwt, $keyOrKeyArray)
             throw new UnexpectedValueException('Algorithm not supported');
         }
 
-        $key = self::getKey($keyOrKeyArray, empty($header->kid) ? null : $header->kid);
+        $key = self::getKey($keyOrKeyArray, property_exists($header, 'kid') ? $header->kid : null);
 
         // Check the algorithm
         if (!self::constantTimeEquals($key->getAlgorithm(), $header->alg)) {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public static function decode($jwt, $keyOrKeyArray)`
`111`	`111`	`throw new UnexpectedValueException('Algorithm not supported');`
`112`	`112`	`}`
`113`	`113`
`114`		`- $key = self::getKey($keyOrKeyArray, empty($header->kid) ? null : $header->kid);`
	`114`	`+ $key = self::getKey($keyOrKeyArray, property_exists($header, 'kid') ? $header->kid : null);`
`115`	`115`
`116`	`116`	`// Check the algorithm`
`117`	`117`	`if (!self::constantTimeEquals($key->getAlgorithm(), $header->alg)) {`