Skip to content

Commit 90552fe

Browse files
committed
fix: fix verify
1 parent 01c5841 commit 90552fe

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

packages/cloud_firestore/cloud_firestore/lib/src/firestore.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ part of cloud_firestore;
1717
/// ```
1818
class FirebaseFirestore extends FirebasePluginPlatform {
1919
FirebaseFirestore._({required this.app})
20-
: super(app.name, 'plugins.flutter.io/firebase_firestore') {
21-
FirebasePluginPlatform.verify(instance);
22-
}
20+
: super(app.name, 'plugins.flutter.io/firebase_firestore');
2321

2422
static final Map<String, FirebaseFirestore> _cachedInstances = {};
2523

@@ -37,6 +35,8 @@ class FirebaseFirestore extends FirebasePluginPlatform {
3735
}
3836

3937
FirebaseFirestore newInstance = FirebaseFirestore._(app: app);
38+
FirebasePluginPlatform.verify(newInstance);
39+
4040
_cachedInstances[app.name] = newInstance;
4141

4242
return newInstance;

packages/cloud_functions/cloud_functions/lib/src/firebase_functions.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ part of cloud_functions;
1111
class FirebaseFunctions extends FirebasePluginPlatform {
1212
FirebaseFunctions._({required this.app, String? region})
1313
: _region = region ??= 'us-central1',
14-
super(app.name, 'plugins.flutter.io/firebase_functions') {
15-
FirebasePluginPlatform.verify(instance);
16-
}
14+
super(app.name, 'plugins.flutter.io/firebase_functions');
1715

1816
// Cached and lazily loaded instance of [FirebaseFunctionsPlatform] to avoid
1917
// creating a [MethodChannelFirebaseFunctions] when not needed or creating an
@@ -52,6 +50,7 @@ class FirebaseFunctions extends FirebasePluginPlatform {
5250

5351
FirebaseFunctions newInstance =
5452
FirebaseFunctions._(app: app, region: region);
53+
FirebasePluginPlatform.verify(newInstance);
5554
_cachedInstances[cachedKey] = newInstance;
5655

5756
return newInstance;

packages/firebase_analytics/firebase_analytics/lib/src/firebase_analytics.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ part of firebase_analytics;
77
/// Firebase Analytics API.
88
class FirebaseAnalytics extends FirebasePluginPlatform {
99
FirebaseAnalytics._({required this.app})
10-
: super(app.name, 'plugins.flutter.io/firebase_analytics') {
11-
FirebasePluginPlatform.verify(instance);
12-
}
10+
: super(app.name, 'plugins.flutter.io/firebase_analytics');
1311

1412
/// Namespace for analytics API available on Android only. This is deprecated in favor of
1513
/// `FirebaseAnalytics.instance.setSessionTimeoutDuration()`.
@@ -48,7 +46,10 @@ class FirebaseAnalytics extends FirebasePluginPlatform {
4846
factory FirebaseAnalytics.instanceFor({required FirebaseApp app}) {
4947
if (kIsWeb || app.name == defaultFirebaseAppName) {
5048
return _firebaseAnalyticsInstances.putIfAbsent(app.name, () {
51-
return FirebaseAnalytics._(app: app);
49+
final instance = FirebaseAnalytics._(app: app);
50+
FirebasePluginPlatform.verify(instance);
51+
52+
return instance;
5253
});
5354
}
5455

packages/firebase_auth/firebase_auth_platform_interface/lib/src/platform_interface/platform_interface_recaptcha_verifier_factory.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ abstract class RecaptchaVerifierFactoryPlatform extends PlatformInterface {
6666
}
6767

6868
/// Ensures that a delegate class extends [RecaptchaVerifierFactoryPlatform].
69-
static void verify(RecaptchaVerifierFactoryPlatform instance) {
69+
static void verifyExtends(RecaptchaVerifierFactoryPlatform instance) {
7070
PlatformInterface.verify(instance, _token);
7171
}
7272

packages/firebase_auth/firebase_auth_platform_interface/test/platform_interface_tests/platform_interface_recaptcha_verifier_factory_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ void main() {
4646
group('verify()', () {
4747
test('calls successfully', () {
4848
try {
49-
RecaptchaVerifierFactoryPlatform.verify(
49+
RecaptchaVerifierFactoryPlatform.verifyExtends(
5050
recaptchaVerifierFactoryPlatform);
5151
return;
5252
} catch (_) {

0 commit comments

Comments
 (0)