Skip to content

Commit 4db12d2

Browse files
authored
Fix incorrect warnings when emulating extensions with httpsTriggers (#6055)
1 parent 197506a commit 4db12d2

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
- Increased extension instance create poll timeout to 1h to match backend (#5969).
22
- Refactored `ext:install` to use the latest extension metadata. (#5997)
3+
- Fixed issue where missing trigger warnings would be wrongly displayed when emulating extensions with HTTPS triggers. (#6055)
34
- Normalized extension root path before usage in `ext:dev:upload`. (#6054)

src/extensions/emulator/triggerHelper.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ export function functionResourceToEmulatedTriggerDefintion(
7777
proto.convertIfPresent(etd, properties, "timeoutSeconds", "timeout", proto.secondsFromDuration);
7878
proto.convertIfPresent(etd, properties, "regions", "location", (str: string) => [str]);
7979
proto.copyIfPresent(etd, properties, "availableMemoryMb");
80-
if (properties.httpsTrigger) {
80+
if (properties.httpsTrigger !== undefined) {
81+
// Need to explcitly check undefined since {} is falsey
8182
etd.httpsTrigger = properties.httpsTrigger;
8283
}
8384
if (properties.eventTrigger) {

0 commit comments

Comments
 (0)