Skip to content

Commit 2360d3c

Browse files
hlshenjoehan
andauthored
Fix status bar showing always (#7289)
* status bar fix * status bar change text --------- Co-authored-by: joehan <joehanley@google.com>
1 parent ead816b commit 2360d3c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

firebase-vscode/src/core/emulators.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,8 @@ export class EmulatorsController implements Disposable {
178178
displayInfo: listRunningEmulators(),
179179
},
180180
};
181-
this.emulatorStatusItem.text = "$(data-connect) Connected to local Postgres";
181+
// TODO: Add other emulator icons
182+
this.emulatorStatusItem.text = "$(data-connect) Emulators: Running";
182183

183184
// data connect specifics; including temp logging implementation
184185
if (
@@ -207,7 +208,7 @@ export class EmulatorsController implements Disposable {
207208

208209
// Updating the status bar label as "running", but don't "show" it.
209210
// We only show the status bar item when explicitly by interacting with the sidebar.
210-
this.emulatorStatusItem.text = "$(data-connect) Connected to local Postgres";
211+
this.emulatorStatusItem.text = "$(data-connect) Emulators: Running";
211212
this.emulatorStatusItem.backgroundColor = undefined;
212213
} catch (e) {
213214
this.emulatorStatusItem.text = "$(data-connect) Emulators: errored";

firebase-vscode/src/data-connect/emulator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class DataConnectEmulatorController implements vscode.Disposable {
2222

2323
// Notify webviews when the emulator status changes
2424
effect(() => {
25-
if (this.isPostgresEnabled) {
25+
if (this.isPostgresEnabled.value) {
2626
this.emulatorsController.emulatorStatusItem.show();
2727
} else {
2828
this.emulatorsController.emulatorStatusItem.hide();

0 commit comments

Comments
 (0)